Core/Misc: Silenced 500 OS X Warnings and removed deprecated finite() method. *Mac OS X fires off over 200 warnings related to gsoap about the deprecated register method. CMake has been patched to remove this warning. *Updated all occurences of finite() to std::isfinite. The method finite() is not standardized by anyone aside from BSD. std::isfinite() however is standarized by C++ *Removed -ncurses and -pthread from OS X compilation. Now that we use Boost and C++11 there is no longer a need for pthread in OS X. All it does is throw a warning. However, ncurses isn't needed either as it's built into the OS X SDK and linked by default.

Note: There are only 5 remaining warnings left when compiling on OS X. I did not attempt to fix these as they were related to 3rd party libraries statically linked into the code. The 5 warnings left are all related to unused variables.
Core/Common: Remove the no longer finite(x) macro for MSVC

Use std::isinfinite(f) instead.
Scripts/ICC: Summon Sealed Chest quest npc's upon the Lich King's Death

TODO: template updates for these npcs and gossips

Closes #10554
Closes #12591 (PR)

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
DB/NPCs: Add missing gossip for Strahad Farsan

Closes #12613
DB/Creature: Update SAI of more creatures

By Malcrom.
DB/Creature: Fix of Doc Mixilpixil gossips

By Malcrom, closes #12617
Core/Spells: Death and Decay

Solves problems with Death and Decay doing LoS check using the caster instead of the center of AOE.
Fix by @PKX
Closes #6345
DB/Gameobject: Spawn Maraudon portal

Closes #10131
Scripts/Feralas: Make Screecher Spirit disappear after clicking on them

This is a temporary solution, the script should be rewritten in SAI

Closes #12298

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
Scripts/WesternPlaguelands: Fix conditions to show gossip of Myranda the Hag (In Dreams quest)

Ref #7519

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
Core/Spells: Solving the double dips in Hammer of the Righteous
Core/Units: IsNonMeleeSpellCast will no longer return false if there's an instant cast spell still arriving at the target with the caster doing a channel
Scripts/Four Horsemen: Horsemen's main spells should only explicitly target players
Script/IoC: Move some spell scripts from spell_generic to isle_of_conquest cpp

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
Scripts/IoC: Rename spell_gen_* spells to spell_ioc_*

(Additions to 6bb63ab7db679d9c)

Closes #12414 (PR)
Core/Spells: Unrelenting Assault shouldn't proc if the target isn't explicitly casting (turns out that UNIT_STATE_CASTING even a instant cast has a 'cast time')
Scripts/Karazhan: Boss Maiden of Virtue - rewrite to events and timer adjustments

Closes #12513 (PR)

Signed-off-by: DDuarte <dnpd.dd@gmail.com>
Core/Units: Properly remove auras that don't pass IsHighestExclusiveAura
Core/BGs: Reputation gained in BGs should be affected by SPELL_AURA_MOD_FACTION_REPUTATION_GAIN
Core/BGs: Reputation gained in BGs should be affected by SPELL_AURA_MOD_REPUTATION_GAIN

An example would be Diplomacy (Racial Passive)