DDF-534

Some initial cleanups and the start of the work on making options / arguments common across different console commands.

This isn't enough to solve DD-534 completely.
I took the comment to be mostly giving background information for why the sizes were different. Would like to hear back from @pklinef though just in case that was not the only intent.

From: Brad Hards <notifications@github.com<mailto:notifications@github.com>>
Reply-To: codice/ddf-catalog <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Thursday, June 26, 2014 at 9:52 PM
To: codice/ddf-catalog <ddf-catalog@noreply.github.com<mailto:ddf-catalog@noreply.github.com>>
Cc: Matt Ramey <matthew.ramey@lmco.com<mailto:matthew.ramey@lmco.com>>
Subject: EXTERNAL: Re: [ddf-catalog] DDF-534 (#11)


In core/catalog-core-commands/src/main/java/org/codice/ddf/commands/catalog/IngestCommand.java:

>              console.println("If the file does indeed exist, try putting the path in quotes.");
>              return null;
>          }
> -
> +
> +        if (deprecatedBatchSize != DEFAULT_BATCH_SIZE) {
> +            // user specified the old style batch size, so use that
> +            printErrorMessage("Batch size positional argument is DEPRECATED, please use --batchsize option instead.");
> +            batchSize = deprecatedBatchSize;
> +        }
> +
>          if (batchSize <= 0) {


I'm not sure if this comment requires changes to the code, or is just explains some background. If it does require changes, can you be more explicit about what the requirement (and suggested solution, if any) is?

—
Reply to this email directly or view it on GitHub<https://github.com/codice/ddf-catalog/pull/11/files#r14279576>.