renamed Trait to BuySell