VMware: Remove unused variable in test_configdrive

TrivialFix

Change-Id: I3b4c55f22e515d9a66311e4c608febf617babc5a
maint: various spelling fixes

Fix typos, identified mainly with misspell-check

TrivialFix

Change-Id: Icb747f9982ce1551042b832e4823c480a5492928
VMware: Remove get_copy_virtual_disk_spec from vmops and vm_util

VMwareVMOps.get_copy_virtual_disk_spec() became a no-op with the
removal of VMwareVCVMOps. This change removes it, and consequently
removes the copy_spec argument to vm_util.copy_virtual_disk, as it was
only ever being passed None.

We also remove vm_util.get_copy_virtual_disk_spec(), which is no
longer called at all after the removal of VMwareVCVMOps.

Change-Id: Ibdc6127143c39b084ea956950503af842a72dc24
Sync oslo lockutils to nova

The commit to be merged:

942e1aa Use file locks by default again
ac995be Fix E126 pep8 errors
15b8352 Remove oslo.log from lockutils

942e1aa is hopefully the fix for the "n-cpu stop about 15 minutes 
before the rest of the test run" problem at the gate. We need to 
make sure this actually fixes the gate problem

Closes-Bug: #1349452

Change-Id: I31265d4e08245879ad72d3e91dcd8be2359ca811
Ironic driver fetches extra_specs when needed

The Ironic driver needs to access flavor['extra_specs'] in certain
situations. This access was erroneously removed during the large patch
series to land the driver in Nova. The corresponding change did not land
in Ironic, because it fails to pass tempest (as does the current Ironic
driver in Nova).

This patch reverts that change.

Change-Id: I525c611aa0e98076477c2a9a279a0f8a47858aac
Closes-bug: 1367007
Specify correct operation type when NVH is raised

When nova-conductor received a NoValidHost (NVH) exception for a
cold migrate or resize operation, its error message back through
the API layer always displayed the string "cold migrate" in the
error text, even when the operation was a resize. This leads to
potentially confusing situations when triaging problems in the
cloud environment.

This patch corrects the error message based on the operation; we use
the flavor IDs as a way to determine what operation is really being
performed. In the case of a resize, different flavor IDs will be
used and they will be indentical in the case of a cold migration.

Note there was a lot of IRC discussion on this as well in terms of
the "algorithm" to check the operation type; the flavor ID check
is also used in the API layer as well since it's the only way you
can determine this given the underlying operation.  We also tried
to make the error message more general, but the consensus was that
was pretty unfriendly from the user's perspective - so we've landed
with this approach again with the end users close to heart.  :-)

Change-Id: I762425b2602c2798b94d3c770f2401dd0aedc942
Closes-Bug: #1364692
Merge "Sync oslo lockutils to nova"
Merge "Ironic driver fetches extra_specs when needed"
Merge "VMware: Remove get_copy_virtual_disk_spec from vmops and vm_util"
Merge "maint: various spelling fixes"
Merge "Specify correct operation type when NVH is raised"
Merge "VMware: Remove unused variable in test_configdrive"