finished assignment 2 commiting