Use assertIn where appropriate

Change-Id: I27038279067183352e5a54766fb74515057d581a
Mention --fixed-ip subnet_id=<..> in help message

Improved help message for port-create --fixed-ip subnet_id=<..> case:
 * ensure it's mentioned when no arguments are passed;
 * fixed wording of --help message to make it clear subnet_id may be
   passed without ip_address.

Change-Id: Ie48099e0445f80dbff78766e42bc548f925cd208
Closes-Bug: #1267465
Combine debug and verbose commandline options

Most of the openstack clients (for example nova) when --debug is specified it
shows the api calls the client is making. However, when debug is passed into
the neutronclient it shows exceptions that have occurred inside the
neutronclient. This patch combines verbose and debug to do the samething.

Change-Id: I6f2e0b17ffbe8fbfa77e26222dae32f5ab1e8866
Closes-bug: #1260489
update coveragerc file

fix missing change from quantumclient to neutronclient in .coveragerc
exclude tests from code coverage calculation

Change-Id: Ie286faaaaad9e9bc72c89422ac628178a30ccc8e
Rename Nicira NVP to VMware NSX in neutronclient

Use new naming scheme to reflect rebranding.

Partial-implements blueprint nicira-plugin-renaming

Change-Id: I694fbda1c228e92a0b910358523787fa742d9ab2
Fixed a minor typo in a docstring

Change-Id: I4d822513cc65662a988c7ad10b01ff04fa7d6890
Fixed get_auth_info() for pre-authenticated clients

When a client is instantiated with pre-defined authorization token,
no authentication is done, so no auth_[tenant|user]_id keys are set
for HTTPClient. As a result, Client.get_auth_info() fails with KeyError.

Fixed the issue by setting those keys on HTTPClient initialization.

Change-Id: Ifc9d6b128286b635346a7bc026fcc55dbd002050
Closes-Bug: 1277120
Merge "Rename Nicira NVP to VMware NSX in neutronclient"
Remove vi modelines

We don't need to have the vi modelines in each source file,
it can be set in a user's vimrc if required.

Change-Id: Ic30e91df1b0e25beda9b8d8c19be58573cdae4f6
Closes-Bug: #1229324
Merge "Fixed get_auth_info() for pre-authenticated clients"
Modify quota-list descripton

'quota-list' is truly to descirbe quotas for tenants who have non-default
quota values.

Change-Id: I9b5cc92afda9ec7ace479f456c303a3ecc5672d0
Closes-bug: #1280519
Work around for httplib2 retries on timeout

httplib2 automatically retries a request on a timeout even if the request
is a POST. This can lead to orphaned objects being created that we
don't know about. This patch sets httplib2.RETRIES to 1 to avoid this.

Note: httplib2.RETRIES is only available in new versions of httplib2.
See: https://code.google.com/p/httplib2/issues/detail?id=124 for more
details.

Co-Authored-By: Ashwin Raveendran <ashw7n@gmail.com>
Co-Authored-By: Sudheendra Murthy <sudhi.vm@gmail.com

Change-Id: I5648b644bb9df1fd2ea219159794d9d122696af0
Closes-bug: #1267649
Don't reuse 'body' for response data

It makes diagnostics in debuggers much harder - we can just use a
different variable name instead.

Change-Id: I69367336cbb0f9f302ef8d484a5d504d2b3869bb
Merge "Mention --fixed-ip subnet_id=<..> in help message"
Merge "update coveragerc file"
Merge "Remove vi modelines"
Merge "Modify quota-list descripton"
Merge "Don't reuse 'body' for response data"
Unexpected response in agent-list command

Problem with 'alive' field. if you try this command you obtain an
unexpected response:

$ neutron agent-list --field agent_type
'alive'

The problem is that the 'alive' field is not checked for instanciate
before to check its value. Under the hood, there is a non catched
Keyerror exception converted to unicode.

Change-Id: I59b313494605f64c5588324d1153614b1c11920f
Closes-Bug: #1271948
Merge "Use assertIn where appropriate"