It is always good practice to put a shell function's positional parameters in a named variable, so this is good, but it should occur at the top of the function, and all uses should refer to the named variable.