more progress on generators
neater generater nearly done