Unreviewed update of test expectations.

Marking media/track/track-cue-rendering-snap-to-lines-not-set.html as
flaky again until WK89167 is fixed.

* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[New Multicolumn] Implement column repainting.
https://bugs.webkit.org/show_bug.cgi?id=95593

Reviewed by Dan Bernstein.
        
Make the new columns repaint properly. Note this code is a significant improvement over the
old multicolumn code in that repaints are properly issued per-column, i.e., no more fuzzy
uniting of rects.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnIndexAtOffset):
(WebCore):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
* rendering/RenderMultiColumnSet.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[DRT] Make simulating a web click on a notification a queued task
https://bugs.webkit.org/show_bug.cgi?id=95546
<rdar://problem/12214170>

Reviewed by Alexey Proskuryakov.

Making the web click happen asynchronously better mimics user interaction with the platform.

* DumpRenderTree/TestRunner.h: Add a flag that determines whether we have a pending notification click.
(TestRunner::hasPendingWebNotificationClick): Exposed so that dump() can check that the flag is
not set.
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump): Assert that the flag is not set.
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::simulateWebNotificationClick): Set the flag, then add a task to click the
notification. In the case where the block gets executed after the flag has been unset, we avoid
performing the click.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127298 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Tests] Add basic tests to http/tests/notifications
https://bugs.webkit.org/show_bug.cgi?id=95493
<rdar://problem/12209303>

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Simplify the passing of the permission policy to just a boolean instead of converting it
back and forth from the NotificationClient::Permission enum.

* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Move the declaration to the section
of functions that are TestRunner SPI.
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setWebNotificationPermission): Use a boolean.
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::setPermissionLevelForTesting):
* WebProcess/Notifications/NotificationPermissionRequestManager.h:
(NotificationPermissionRequestManager):

* win/WebKit2.vcproj: Add WKNotificationPermissionRequest.{h,cpp}.
* win/WebKit2Generated.make: Export WKNotificationPermissionRequest.h.

Tools:

Add permission request support for WTR.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::decidePolicyForNotificationPermissionRequest): Always allow.
* WebKitTestRunner/TestController.h:
(TestController):

LayoutTests:

* http/tests/notifications/request-expected.txt: Added.
* http/tests/notifications/request.html: Added. This test requests permission. DRT/WTR
is expected to accept it, and we verify that both the parameter in the callback function,
and Notification.permission, are both set to "granted".
* http/tests/notifications/show-expected.txt: Added.
* http/tests/notifications/show.html: Added. This test checks that the various permission
APIs on TestRunner work.

Legacy analog to above tests.
* http/tests/notifications/legacy/request-expected.txt: Added.
* http/tests/notifications/legacy/request.html: Added.
* http/tests/notifications/legacy/show-expected.txt: Added.
* http/tests/notifications/legacy/show.html: Added.

* http/tests/resources/js-test-post-async.js: Added. This will be used for most tests since
the events are called asynchronously.
* http/tests/resources/js-test-pre.js: Updated from fast/js/resources.
* http/tests/resources/notifications-test-pre.js: Added. Adds a helper function to complete
the test, and defines the domain of http/tests.
(testCompleted):

Skip.
* platform/chromium/TestExpectations: Skip on Android. Filed 95506 to bring Chromium support.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/Skipped:
* platform/qt/Skipped: Filed 95507 to bring Qt support.
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127299 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove extraneous includes (Node.h, Document.h, Element.h, RenderObject.h)
https://bugs.webkit.org/show_bug.cgi?id=95259

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-08-31
Reviewed by Sam Weinig.

Node.h, Document.h, Element.h, and RenderObject.h are four of the most
expensive headers to include. This patch removes them from many of the
places they are not needed. There is a minor compile-time performance
boost.

* dom/ElementShadow.h:
* dom/Range.h:
(WebCore):
* dom/TreeScopeAdopter.h:
(WebCore):
* editing/VisiblePosition.h:
(WebCore):
* html/HTMLCollection.h:
(WebCore):
* html/parser/HTMLElementStack.h:
* html/parser/HTMLTreeBuilder.h:
(WebCore):
* html/track/WebVTTParser.h:
(WebCore):
* inspector/InspectorCSSAgent.h:
(WebCore):
* inspector/InspectorInstrumentation.h:
(WebCore):
* inspector/InspectorOverlay.h:
* loader/ImageLoader.h:
* loader/TextTrackLoader.h:
(WebCore):
* platform/chromium/PopupListBox.cpp:
* platform/chromium/PopupListBox.h:
(WebCore):
* platform/graphics/MediaPlayer.h:
(WebCore):
* rendering/FilterEffectRenderer.h:
* rendering/InlineFlowBox.cpp:
* rendering/RenderCounter.cpp:
* rendering/RenderGeometryMap.h:
(WebCore):
* rendering/RenderInputSpeech.h:
(WebCore):
* rendering/RenderMediaControls.h:
(WebCore):
* rendering/RenderMediaControlsChromium.h:
(WebCore):
* rendering/RenderQuote.cpp:
* rendering/RenderQuote.h:
(WebCore):
* rendering/RenderScrollbar.h:
(WebCore):
* rendering/RenderText.h:
(WebCore):
* rendering/RenderTheme.h:
(WebCore):
* rendering/RenderThemeChromiumSkia.h:
(WebCore):
* rendering/svg/RenderSVGResourceMarker.h:
(WebCore):
* svg/graphics/filters/SVGFilterBuilder.h:
(WebCore):
* xml/NativeXPathNSResolver.h:
(WebCore):
(NativeXPathNSResolver):
(WebCore::NativeXPathNSResolver::create):
* xml/XPathStep.h:
(WebCore):
(XPath):
(Step):
(NodeTest):
(WebCore::XPath::Step::NodeTest::NodeTest):
(WebCore::XPath::Step::NodeTest::kind):
(WebCore::XPath::Step::NodeTest::data):
(WebCore::XPath::Step::NodeTest::namespaceURI):
(WebCore::XPath::Step::NodeTest::mergedPredicates):
(WebCore::XPath::Step::axis):
(WebCore::XPath::Step::nodeTest):
* xml/parser/NewXMLDocumentParser.cpp:
* xml/parser/NewXMLDocumentParser.h:
(WebCore):
* xml/parser/XMLToken.h:
* xml/parser/XMLTreeBuilder.cpp:
* xml/parser/XMLTreeBuilder.h:
(WebCore):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127300 268f45cc-cd09-0410-ab3c-d52691b4dbfc
(Regression: r126774): Fix crash when scrolling after removing inline sticky element
https://bugs.webkit.org/show_bug.cgi?id=95584

Reviewed by Dave Hyatt.

Source/WebCore:

Move fixed/sticky registration and unregistration with the FrameView from
RenderBox and RenderInline into RenderBoxModelObject, which also
fixes the issue that inlines didn't unregister themselves on destruction.

Test: fast/css/sticky/remove-inline-sticky-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed): Code moved to RenderBoxModelObject. No need
to null-check style.
(WebCore::RenderBox::styleWillChange): Code moved to RenderBoxModelObject.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::willBeDestroyed): Remove fixed objects. Check
isPositioned() to avoid this work for most non-positioned renderers.
(WebCore::RenderBoxModelObject::styleWillChange): Register and unregister fixed
and sticky objects with the FrameView.
* rendering/RenderInline.cpp: styleWillChange() is no longer needed.
* rendering/RenderInline.h: Ditto.

LayoutTests:

Testcase removes an inline sticky, then scrolls.

* fast/css/sticky/remove-inline-sticky-crash-expected.txt: Added.
* fast/css/sticky/remove-inline-sticky-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nrwt: use scm instead of calling svn directly to get the revision in json results generator
https://bugs.webkit.org/show_bug.cgi?id=89616

Reviewed by Eric Seidel.

Add the new 'executive' optional function argument to the SCM.in_working_directory
class method. This way we get to reuse an Executive instance which is necessary in testing
when we're operating with a mock version of the object.

In JSONResultsGeneratorBase, it's now possible to get the current SVN revision by using
the SCMDetector with the generator's FileSystem and Executive instances.

* Scripts/webkitpy/common/checkout/scm/detection.py:
(SCMDetector.detect_scm_system):
* Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
(SCMDetectorTest.test_detect_scm_system): Update the unit test to capture the mock
Executive output and test it against expected output.
* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.in_working_directory):
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
(JSONResultsGeneratorBase.__init__):
(JSONResultsGeneratorBase._get_svn_revision):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127302 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix the Debug builds after r127277

Unreviewed.

One assertion was not updated in r127277. The encapsulation of CSSParserString's length
has changed and now use an accessor.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-08-31

* css/CSSParser.cpp:
(WebCore::CSSParser::storeVariableDeclaration):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Not reviewed.

Rolled out http://trac.webkit.org/changeset/127293 because it broke
inspector tests on Windows.

    Shrink activation objects by half
    https://bugs.webkit.org/show_bug.cgi?id=95591

    Reviewed by Sam Weinig.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] DEPS roll with a test skip.
https://bugs.webkit.org/show_bug.cgi?id=95601

Unreviewed gardening & DEPS roll.

Source/WebKit/chromium:

fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)

* DEPS:

LayoutTests:

fast/frames/cached-frame-counter.html was never the most stable test, and now it's failing on more platforms. Marking it flaky, along with a DEPS roll (earlier attempts at the DEPS roll failed on this)

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
objc_msgSend and IMP should be cast appropriately before using
https://bugs.webkit.org/show_bug.cgi?id=95242

Reviewed by Benjamin Poulain.

Fix for older compilers. Pass id as the return type to the template
instead of relying on default type.

Source/WebKit/mac:

* WebView/WebDelegateImplementationCaching.mm:
(CallDelegate):
(CallFormDelegate):
* WebView/WebHTMLView.mm:
(setCursor):
(setNeedsDisplayInRect):

Source/WTF:

* wtf/Functional.h:
(WTF::R):
* wtf/ObjcRuntimeExtras.h:

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(drt_NSFontManager_availableFontFamilies):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::wtr_NSFontManager_availableFontFamilies):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Adding expected failing results for accessibility/canvas tests.
https://bugs.webkit.org/show_bug.cgi?id=95598

Windows description and role strings don't match up with what is expected on Mac. 
Particularly, they do not include the "AX" at the beginning of the descriptions/roles of canvas fallback content.

* platform/win/accessibility/canvas-description-and-role-expected.txt: Added.
* platform/win/accessibility/canvas-fallback-content-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Skip http/tests/notifications on Lion, since there is no support.

* platform/mac-lion/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unskip plugins/npruntime/delete-plugin-within-* tests on Windows
https://bugs.webkit.org/show_bug.cgi?id=95597

Reviewed by Darin Adler.

* platform/win/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening. Adding fast/css/nested-layers-with-over.html to Windows skip list.
https://bugs.webkit.org/show_bug.cgi?id=95388

* platform/win/Skipped:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Put compositor client interfaces in separate headers, normalize naming
https://bugs.webkit.org/show_bug.cgi?id=95522

Reviewed by Adam Barth.

Source/WebCore:

Client interfaces should be in their own headers so code implementing these interfaces do not have to
transitively #include all of the compositor internals.

We call things 'clients' not 'delegates' in the compositor.

* WebCore.gypi:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerPainter::ContentLayerPainter):
(WebCore::ContentLayerPainter::create):
(WebCore::ContentLayerPainter::paint):
(WebCore::ContentLayerChromium::create):
(WebCore::ContentLayerChromium::ContentLayerChromium):
(WebCore::ContentLayerChromium::drawsContent):
(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore):
(ContentLayerPainter):
(ContentLayerChromium):
(WebCore::ContentLayerChromium::clearClient):
* platform/graphics/chromium/TextureLayerChromium.cpp:
* platform/graphics/chromium/TextureLayerChromium.h:
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore):

Source/WebKit/chromium:

* src/WebContentLayerImpl.cpp:
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebExternalTextureLayerImpl.h:
* src/WebLayerTreeViewImpl.h:
(WebCore):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WebKitTests::ContentLayerChromiumWithUpdateTracking::create):
(WebKitTests::ContentLayerChromiumWithUpdateTracking::ContentLayerChromiumWithUpdateTracking):
(WebKitTests::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WebKitTests::CCLayerTreeHostTestAtomicCommit::CCLayerTreeHostTestAtomicCommit):
(WebKitTests::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::CCLayerTreeHostTestAtomicCommitWithPartialUpdate):
(WebKitTests::CCLayerTreeHostTestLostContextWhileUpdatingResources::CCLayerTreeHostTestLostContextWhileUpdatingResources):
(CCLayerTreeHostTestLostContextWhileUpdatingResources):
* tests/ContentLayerChromiumTest.cpp:
(WebKit::MockContentLayerChromiumClient::MockContentLayerChromiumClient):
(WebKit::TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
The fast/forms/ file tests were moved in the file sub-directory in r96918. Remove the
old entries from the Skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
objc_msgSend and IMP should be cast appropriately before using
https://bugs.webkit.org/show_bug.cgi?id=95242

Reviewed by Benjamin Poulain.

Follow on fix for Mac EWS - use objc-runtime.h instead of runtime.h so
that it finds the declaration for objc_msgSend.

* UIProcess/API/mac/PDFViewController.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
compositing/tiling/huge-layer* flakey
https://bugs.webkit.org/show_bug.cgi?id=48454

These tests were disabled in r89631. Remove them from the Skipped list so that
run-webkit-tests doesn't try to find them.

* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/http/tests/websocket/tests/hixie76/frame-lengths.html was removed. Remove it from the Skipped list.

* platform/mac-wk2/Skipped:
* platform/qt-arm/Skipped:
* platform/wincairo/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127315 268f45cc-cd09-0410-ab3c-d52691b4dbfc