Fix some spellmods.
[z2394] Fix CMSG_CHAT_IGNORED

The added byte was actually introduced in 2.4.1

Signed-off-by: stfx <stfx@hotmail.de>
[z2395] Fix use of config values related to quest-status and level

This fixes use of negative value in config values Quests.LowLevelHideDiff and Quests.HighLevelHideDiff

Also add some documentation around the related code

Thanks to Neotmiren for pointing and to cala for testing.

(based on commit [12536] - 51c5713)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s2045] - 0cc7d85)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2396] Immediately remove corpses when ForcedDespawn is used

Thanks to Neotmiren for pointing, special thanks to cala for testing!

(based on commit [12537] - 4c3ff5c)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s2046] - a4390c7)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2397] Implement some custom use for Effect Activate Object spells

This will fix the summoning events for the Wind Stones, Ice Stones and Skettis bosses

(based on commit [12538] - 91268f6)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s2047] - fccc3f7)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2398] Add CMake source groups to target 'shared'

This is the exact same grouping as it is currently in the VC 2012 files.

(based on commit [12541] - 82b02fc)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s2050] - 1582280)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2399] Add CMake source groups to target 'framework'

This is the exact same grouping as it is currently in the VC 2012 files.

(based on commit [12542] - bd2eb31)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s2051] - 5385dd7)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2400] Add CMake source groups to target 'game'

This is the exact same grouping as it is currently in the VC 2012 files.
These groupings will have to be refactored at some point as they are not
very logical.

(based on commit [12543] - 0088ce3)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s2052] - 57517ba)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
[z2401] CMake: generic way to build a script library

Added new parameter INCLUDE_BINDINGS_DIR which can be set to the name of a
folder inside src/bindings/.

Includes the script library in src/bindings/ with the defined name.
The name must correspond to the name of the folder and the folder must contain
a valid CMakeLists.txt

Note: if you currently use a script library, you will probably get a merge
problem on src/bindings/CMakeLists.txt as you will have modified this file
manually. Please use the new version of this file and rerun CMake once with the
parameter -DINCLUDE_BINDINGS_DIR=ScriptDev2 (if you are not using SD2 but
another script library, replace ScriptDev2 with the name of the folder in
src/bindings/).

If you do not use a script library you should not have any merge problems
and you don't need to do anything.

(based on commit [12544] - d14ec5b)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>

(based on commit [s2053] - 9bf61af)

Signed-off-by: Xfurry <xfurry@scriptdev2.com>
Merge pull request #39 from sidsukana/master

Fix some spellmods.
Fixes Minor Agility Enchant
Fixes Minor Agility enchantment on cloak due to wrong EquipedItemClass in DBC
Removes extra mods

Removes extra mods because they were related to TBC features such as PvP
diminishing returns
Closes cmangos issue #227
Fixed SMSG_SPELL_FAILED_OTHER

fixes the spell visual effect remaining after spell is interrupted
Fix by Evairfairy from SilverpineProject
Fix spirit based mana regen

Fix spirit based mana regen because mana regen was too quick, especially
with spells like innervate or evocate or when players have a high ratio
spirit/mana points.
Unlike TBC and later expansion, spirit mana regen values per class were
not stored in DBC in Classic but used formulas as described below
http://www.wowwiki.com/Mana_regeneration?direction=prev&oldid=103895
However, those formulas give regen values per tick, a tick occuring
every 2 sec, the returned value must be cut by half.
source: http://www.wowwiki.com/Talk:Mana_regeneration#Untitled
Merge pull request #46 from cala/manaregen

Fix spirit based mana regen
Merge pull request #45 from cala/cloakenchantagility

Fixes Minor Agility Enchant

Closes cmangos/issues#225
Merge pull request #47 from cala/interruptspell

Fixed SMSG_SPELL_FAILED_OTHER
Merge pull request #44 from cala/removeMods

Removes extra mods

Closes cmangos/issues#227
[z2402] Revert "[z1818] make armor bonuses from certain items be unaffected by base armor mods"

Thanks to @Velvet
Fix Rockbiter Weapon and remove some TBC-specific code.

Also clean-up SPELL_EFFECT_ENCHANT_ITEM_TEMPORARY and fix some enchantment
durations.