Remove "this->".

For most member function calls we do not use "this->" in this file.
Remove the rest for consistency.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205550 91177308-0d34-0410-b5e6-96231b3b80d8
Remove "virtual" and add "override".

Seems clang-modernize couldn't add "override" to nested classes, so
doing it by hand. Also removed unused virtual member function that
is not overriding anything, that seems to have been added by mistake.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205552 91177308-0d34-0410-b5e6-96231b3b80d8
Add empty() to atom_collection.

"x.empty()" is more idiomatic than "x.size() == 0". This patch is to
add such method and use it in LLD.

Differential Revision: http://llvm-reviews.chandlerc.com/D3279

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205558 91177308-0d34-0410-b5e6-96231b3b80d8
Expand 'auto' that's hard for human to deduce its real type.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205564 91177308-0d34-0410-b5e6-96231b3b80d8
Fix ELFFileNode::resetNextIndex().

ELFLinkingContext has a method addUndefinedAtomsFromSharedLibrary().
The method is being used to skip a shared library within --start-group
and --end-group if it's not the first iteration of the group.

We have the same, incomplete mechanism to skip a shared library within
a group too. That's implemented in ELFFileNode. It's intended to not
return a shared library on the second or further iterations in the
first place. This mechanism is preferred over
addUndefinedAtomsFromSharedLibrary because the policy is implemented
in Input Graph -- that's what Input Graph is for.

This patch removes the dupluicate feature and fixes ELFFileNode.

Differential Revision: http://llvm-reviews.chandlerc.com/D3280

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205566 91177308-0d34-0410-b5e6-96231b3b80d8
Early return.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205567 91177308-0d34-0410-b5e6-96231b3b80d8
Fix comments.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205568 91177308-0d34-0410-b5e6-96231b3b80d8
Simplify two if's.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205569 91177308-0d34-0410-b5e6-96231b3b80d8
Minor cleanup.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205570 91177308-0d34-0410-b5e6-96231b3b80d8
Move code into a helper function.

Move code that always runs after doUndefinedAtom into doUndefinedAtom
for readability.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205574 91177308-0d34-0410-b5e6-96231b3b80d8
Do not check deadStripNever twice.

Atoms with deadStripNever attribute has already been added to the
dead strip root set at end of Resolver::doDefinedAtom, so no need
to check it for each atom again.

Differential Revision: http://llvm-reviews.chandlerc.com/D3282

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205575 91177308-0d34-0410-b5e6-96231b3b80d8
Replace a recursion with a loop for speed.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205576 91177308-0d34-0410-b5e6-96231b3b80d8
Minor cleanups.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205578 91177308-0d34-0410-b5e6-96231b3b80d8
Update comment.

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205579 91177308-0d34-0410-b5e6-96231b3b80d8
Rename getInputGraph() and getNextFile().

Seems getSomething() is more common naming scheme than just a noun
to get something, so renaming these members.

Differential Revision: http://llvm-reviews.chandlerc.com/D3285

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205589 91177308-0d34-0410-b5e6-96231b3b80d8
Return a vector rather than mutating a given one.

This is cleaner and as efficient as before.

Differential Revision: http://llvm-reviews.chandlerc.com/D3284

git-svn-id: https://llvm.org/svn/llvm-project/lld/trunk@205590 91177308-0d34-0410-b5e6-96231b3b80d8