changes related to popup