Hi,

 

A question on this change. My understanding of surefire is that it is required for testing if you want reports. Can I assume that the reason you say it is not needed is because it is being included somewhere else? I have required it when doing testing without Arquillian.  I see that the port settings are now in arquillian.xml so I see why they have to go. The context.xml file is what I always used with Servlets and JSPs but Eclipse keeps deleting the file.

 

Ken

 

 

From: Bartosz Majsak [mailto:notifications@github.com] 
Sent: February 22, 2014 3:47 PM
To: omniprof/ArquillianDemo01
Subject: Re: [ArquillianDemo01] Fixed test and project setup. (#1)

 

In ArquillianDemo01/pom.xml:

> -                            unit tests of an application -->
> -                    <plugin>
> -                            <groupId>org.apache.maven.plugins</groupId>
> -                            <artifactId>maven-surefire-plugin</artifactId>
> -                            <version>2.16</version>
> -                            <configuration>
> -                                   <systemPropertyVariables>
> -                                           <!-- randomize the server port -->
> -                                           <tomee.httpPort>-1</tomee.httpPort>
> -                                           <tomee.stopPort>-1</tomee.stopPort>
> -                                           <tomee.classifier>${tomee.classifier}</tomee.classifier>
> -                                           <tomee.version>${tomee.version}</tomee.version>
> -                                   </systemPropertyVariables>
> -                            </configuration>
> -                    </plugin>
> +        <!-- Testing dependencies -->

This should not be in the profile, as we use these libs in src/test/java

—
Reply to this email directly or view it on GitHub <https://github.com/omniprof/ArquillianDemo01/pull/1/files#r9972938> .  <https://github.com/notifications/beacon/4064849__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwODYzNDg0NiwiZGF0YSI6eyJpZCI6MjYyNDE0MjF9fQ==--926b94e3f035c00e6252480b003a5da2a456f7bd.gif>