Make sure that gateway is in CIDR range by default

Git commit c3706fa2 introduced the force_gateway_on_subnet
option that verified that the defined gateway is in the CIDR
range of a newly created or updated subnet. However, the default
value was False for backwards compatability reasons. The default
will change to True and the option will be marked as deprecated.

For IPv6, the gateway must be in the CIDR only if the gateway
is not a link local address.

DocImpact
Change-Id: I04fd1caec6da5dceee3f736b3f91f2468150ba2a
Closes-Bug: #1304181
NSX: remove duplicate call to set_auth_cookie()

Change-Id: Ie883f670aa18f1b8a2561e02b388f903f9cbd03b
Closes-bug: 1347078
Move Cisco VPN RESTapi URI strings to constants

Cisco VPN RESTapi URI strings are currently spread out
throughout the cisco vpn device driver code. This create
challenge towards consistently using REST resource identifiers
as this code gets enhanced in the future. This change moves
those URIs as string contents towards the top of the device
driver file.

This addresses the review comment received during the
cisco-vpnaas BP implementation.

Change-Id: I17e02cca95b1d14d9218f1a2745780bd14c9f89d
Closes-Bug: #1313801
ofagent: Stop monitoring ovsdb for port changes

Perform dumb polling instead.
Now ofagent port monitoring is mostly ovsdb-free.
(except _find_lost_vlan_port stuff, which is planned to be retired
by blueprint ofagent-merge-bridges)

Partially-Implements: blueprint ofagent-port-monitor
Change-Id: Ib4701f7c8ea0ee03229d207c0fbbf6f42a55aecb
Big Switch: Only update hash header on success

This patch moves the hash update call into the success block
of the server manager so the database isn't updated with
a hash header from an error response. Additionally, it prevents
the hash from being updated to an empty value if the hash header
is not present in the response.

Closes-Bug: #1348766
Change-Id: I512d01f9bb91b208dd58883d2464951ecc6748e1
Do not assume order of network_uuid's

This fixes the neutron.tests.unit.test_linux_dhcp.TestDnsmasq
.test_existing_dhcp_networks unit test that breaks with a
randomized PYTHONHASHSEED (see the bug report).

The test assumed that the network_uuid's list was sorted, so sort
the result before comparing.

Note: There are several other unrelated unit tests that also break with a
randomized PYTHONHASHSEED, but they are not addressed here. They will be
addressed in separate patches.

Partial-bug: #1348818
Change-Id: Ia6f742e1fae0687164b841beebb4efcf31ff2625
Merge "Make sure that gateway is in CIDR range by default"
Merge "Do not assume order of network_uuid's"
Merge "NSX: remove duplicate call to set_auth_cookie()"
Remove redundant topic from rpc calls

RpcProxy sets by default topic=self.topic, there's no need to specify
it explicitly in derived class, unless it is overridden

Change-Id: I19b9a67072a7f3c42e3b0e4ba412241a056a79a3
Closes-bug: 1348180
Merge "ofagent: Stop monitoring ovsdb for port changes"
Radware: When a pip is needed, reuse the Port

When a pip (Proxy IP) is needed by the driver, do not create
a new Neutron Port every time a pip is needed. Reuse the
existing Port.

Change-Id: I769a9d85e217b30a1ea4d09449ff39bf1ab23c5a
Closes-bug: #1349895
Merge "Big Switch: Only update hash header on success"
Merge "Remove redundant topic from rpc calls"
Merge "Radware: When a pip is needed, reuse the Port"
Merge "Move Cisco VPN RESTapi URI strings to constants"