hm for some reason i thought the response body was empty for deletes, but
apparently not a97d88c


On Mon, Apr 7, 2014 at 5:18 PM, Alex Zylman <notifications@github.com>wrote:

> In salt/_modules/hk_collaborator.py:
>
> > +
> > +def list(token, app):
> > +    '''
> > +    List all collaborators for a Heroku app. See https://devcenter.heroku.com/articles/platform-api-reference#collaborator-list.
> > +
> > +    CLI Example:
> > +
> > +    .. code-block:: bash
> > +
> > +        sudo salt-call --local hk_collaborators.list <token> <app>
> > +    '''
> > +    r = requests.get('https://api.heroku.com/apps/{}/collaborators'.format(app),
> > +                     headers={'Authorization': 'Bearer ' + token,
> > +                              'Accept': 'application/vnd.heroku+json; version=3'})
> > +    if not r.ok:
> > +        log.error('Error making Heroku API request: {}'.format(r))
>
> I think True or heroku response both make sense, but I think that createand
> delete should be consistent, whereas right now one returns True and one
> returns response.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/Clever/salt-org/pull/3/files#r11368656>
> .
>