diego staging completion handler handles failure
Change 3 polluting tests to non-transactional
Pollution Detection option added to specs

DETECT_POLLUTING_SPECS=true enables comparison of row count
for each table before and after each spec to detect pollution

[#72144466]
Wrap a describe block around a test case that did not have one
appease RuboCop: AssignmentInCondition
Run specs without parallel_test on travis

* Also include the DETECT_POLLUTING_SPECS flag

[#71948064]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Correct api doc for positioning buidpacks

Added the required buildpack guid to the resource name and removed stale
comment about 'position 0` buildpacks.

[#71328862]
Update API Docs checksum

Signed-off-by: Joseph Palermo <jpalermo@pivotallabs.com>
Remove non_transactional flag from UsageEvent repo specs

* We stubbed truncate with dataset.destroy for test only. It should have the
  same behavior, but will not autocommit the transaction in mysql.
* Removing the non_transactional flag will greatly increase the speed of each
  spec affected

[#71446796]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Reseed stacks when resetting the database in test

[#71446796]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Remove non_transactional flag from service broker specs

* It appears as if only one spec, "does not delete the broker", depended on
  the non_transactional behavior.

[#71446796]

Signed-off-by: Michael Fraenkel <fraenkel@us.ibm.com>
Reintroduce parallelism to avoid Travis timeouts

- Split suites by services/non_services
- Split suites by transactional/non_transactional
- Separate api specs and rubocop from the rest

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Consolidate rubocop and api specs

To free up a Travis worker sooner [#71446796]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Explain why we use non_transactional isolation in service_broker_spec

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Configurable scope for Dashboard Clients

* Dashboard clients are given scope of cc_service_broker_client but no
* more than openid, cloud_controller.read, cloud_controller.write, and
* cloud_controller_service_permissions.read.

[#71594888]
Remove unused argument

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Remove unused references to oracle in .travis.yml

[#71446796]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Move db creation into rake tasks

To make this easier to run locally [#71446796]

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Stop installing faraday in Travis

We think this is not used

Signed-off-by: James Myers <jmyers@pivotallabs.com>
Re-order before/after scripts

Makes it easier to see the order in which they run [#71446796]

Signed-off-by: James Myers <jmyers@pivotallabs.com>