Use mock's call assert methods over call_args_list

The way we're checking the value of call_args_list on a mock method is
essentially what assert_called_once_with() since we also know the
method is only called once. In other cases, we can use
assert_has_calls().

I'm slightly nervous of using call_args_list because it's the kind of
thing you could imagine changing in future, even though it's not
marked private.

Change-Id: I7eb3d095f7a1ff9a4abc9e027193d4918d0cda6c
Add release notes up to 1.3.0a9

Change-Id: I978a483e8b121731f838d54e60651c80471793cb
Build log_handler documentation

When log_handler.py was added to oslo.messaging changes weren't made to
publish the documentation. This patch ensures the docs for log_handler
are built.

Change-Id: Ibf60f648ad07875fb4c61427e601b6b268a95f53
Closes-Bug: 1286984
Updated from global requirements

Change-Id: I30e46e95cbfc3024b1a1ab0de8bd79bf9e80d322
Remove vim header

We don't need vim modelines in each source file, it can be set in
user's vimrc.

Change-Id: I615f1ffc7e097f1ddbd908a512f1cb988489e871
Closes-Bug: #1229324
Use driver's notify_send() method again

Drivers have a notify_send() method which allows for special semantics
to be implemented for notification sending. During the port over to
oslo.messaging, it appears we stopped using this and switched to just
using topic_send() instead.

Lets restore the use of notify_send() so that we don't lose behaviours
like I9f8dfd6eaf3996be58fecff6ad91508bdcef23f3 added.

Change-Id: Id0ad0431d3e2b1bfe21723e7f3b1842c2d3a9546
Add kombu driver library to requirements.txt

The RabbitMQ driver is the default driver for oslo.messaging, so it
makes some sense to require this by default. This is consistent with
the way e.g. Nova has always required kombu.

Change-Id: Ibcab58e3f3edce794b571cfabc0a5bcf96c9b47e
Closes-Bug: #1288425
Merge "Add kombu driver library to requirements.txt"
Merge "Build log_handler documentation"
Merge "Remove vim header"
Clean up for qpid tests

Use the config object in the base class, and define a local
base class for managing connections instead of repeating
that code in several places.

Change-Id: I7816a467da449ba172dbaa23e58b511adc1ba40a
Fixed the issue for pop exception

Fixed the issue so that two
threads do not pop the list at the same time
Closes-Bug: #1283926
Change-Id: I693407495c18c3e4a0ca2d8d94c4f4ed179371bf
Add unit test to check the order of Qpid hosts on reconnect

Change-Id: I32e20c0e747e6489dab4b0358d422b8a9c6b982e
Partial-Bug: 1261631
Refactor AMQP message broker selection

Drop redundant variable, make code more clean.

Partial-Bug: #1261631

Change-Id: I5fd71ce3bcd3a82839204ee1fb130de3a3e1d3ac
Fixed possible pep8 failure due to pyflakes bug

There is a bug in pyflakes that may trigger F811 violation when import
is not used in a file before its redefinition in local class method
scope, even though it's used in other classes later in the same file.

Change-Id: Ie611e2ff93c59b01a2695c3d944cfe118f874547
Related-Bug: #1297161
Use messaging_conf fixture configuration by default

This simplifies usage of messaging_conf fixture, reduces explicit
cleanup and option registration code in unit tests.

Change-Id: If1dea548c4a58abfc8ce4967710a061c9058628c
Fixed inconsistent EventletContextManagerSpawnTest failures

The test spawns a greenthread and expects it to complete after
eventlet.sleep(0) call. The problem is that if there are other
greenthreads currently running, sleep(0) may switch to unexpected
thread, which may result in test thread not being invoked at all.
Instead of assuming no other green threads are running at the moment
of test execution, explicitly wait() for the test thread.

Change-Id: Id45307860733658638b74ed3a713493df8c1080d
Closes-Bug: #1282706
Merge "Add release notes up to 1.3.0a9"
Merge "Refactor AMQP message broker selection"
Merge "Fixed inconsistent EventletContextManagerSpawnTest failures"