[SPARK-4006] Block Manager - Double Register Crash

This issue affects all versions since 0.7 up to (including) 1.1

In long running contexts, we encountered the situation of double register without a remove in between. The cause for that is unknown, and assumed a temp network issue.

However, since the second register is with a BlockManagerId on a different port, blockManagerInfo.contains() returns false, while blockManagerIdByExecutor returns Some. This inconsistency is caught in a conditional statement that does System.exit(1), which is a huge robustness issue for us.

The fix - simply remove the old id from both maps during register when this happens. We are mimicking the behavior of expireDeadHosts(), by doing local cleanup of the maps before trying to add new ones.
    
Also - added some logging for register and unregister.

https://issues.apache.org/jira/browse/SPARK-4006


This seems too much detail to log as INFO, or even DEBUG. I think the message you have down there is sufficient.