Is it really necessary if we’re just reading the objects from the DB?

From: Gustavo Lopes [mailto:notifications@github.com]
Sent: vrijdag 7 maart 2014 11:37
To: thehyve/transmart-core-db
Cc: Jan Hudecek
Subject: Re: [transmart-core-db] Vcf implementation (#20)


In grails-app/domain/org/transmartproject/db/dataquery/highdim/vcf/DeVariantSubjectDetailCoreDb.groovy:

> +        def alts = alt.split(/\s*,\s*/)

> +        assert mafIndx < alts.length, "Could not find $mafIndx position in $alt"

> +        alts[mafIndx]

> +    }

> +

> +    @Override

> +    Double getMaf() {

> +        if (!getAdditionalInfo()['AF']) {

> +            return null

> +        }

> +        def afs = parseNumbersList(additionalInfo['AF'])

> +        if (!afs) {

> +            return null

> +        }

> +        afs.max()

> +    }

Don't forget to make these transient.

—
Reply to this email directly or view it on GitHub<https://github.com/thehyve/transmart-core-db/pull/20/files#r10378968>.