It's nice that you've added parameters for ascending and numPartitions, but nicer still would be to use them :)