Validate no_of_bits in ws_sign_ext32 and ws_sign_ext64

The result of the '<<' expression is undefined if no_of_bits - 1 is negative.

Change-Id: I3fff09afe414bdd9d6736ee351f1c542c503b93d
Reviewed-on: https://code.wireshark.org/review/4698
Reviewed-by: Evan Huus <eapache@gmail.com>
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Don't check the checksum if we're encapsulated in an (ICMP) error packet.

This is the case when an ICMP echo is returned (e.g., because it's too big).

This effectively applies SVN rev 36193 to ICMPv6.

Bug: 10620
Change-Id: I29aeaabc2467c818714df448e39b3a93027c8961
Reviewed-on: https://code.wireshark.org/review/5030
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Qt: Limit the amount of Follow Stream text.

QTextEdit + QTextDocument don't handle large amounts of data very well.
Truncate our displayed text after 2 MB.

Change-Id: I0b549a0b05a490272bc0d34af0f2c6661c548d0f
Reviewed-on: https://code.wireshark.org/review/5042
Reviewed-by: Gerald Combs <gerald@wireshark.org>
packet-mq: Use value_string_ext  for big value string. more struct dissected

Use of value_string_ext for big value_strign array, sort them, to force use the btree search
parse more integer value with value_string

Bug: 9367
Change-Id: I49625cf2d46e0974cddde2c7b1767cb7d06ec47d
Reviewed-on: https://code.wireshark.org/review/5037
Petri-Dish: Bill Meier <wmeier@newsguy.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Bill Meier <wmeier@newsguy.com>
DNS: fix display of A6 address suffix field

Bug: 10652
Change-Id: Ibd119177feecd27d0c6baba255e7e3da37b131bd
Reviewed-on: https://code.wireshark.org/review/5043
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Ethernet: fix a trivial typo

Change-Id: Ibf623aa9e7153e7d54dda1000face1bac42a0088
Reviewed-on: https://code.wireshark.org/review/5045
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Announce messages should only have a TLV if the message length is > 64.

Also, cleaned up a unnecessary global variable.

Bug: 10611
Change-Id: I8ef5658eeb1f7a240b508833baac64719af144d8
Reviewed-on: https://code.wireshark.org/review/5029
Reviewed-by: Evan Huus <eapache@gmail.com>
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
print: do not try to add an empty hex stream to PDML output for a text only hf

Bug: 10651
Change-Id: If38af2879b9a20f4755a7843f20c7327d66c95b1
Reviewed-on: https://code.wireshark.org/review/5054
Reviewed-by: Evan Huus <eapache@gmail.com>
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
DNS: fix dissection of ISDN RR Sub Address field

Bug: 10650
Change-Id: I3411d4e5ef534a663940974d98c351976005ee8e
Reviewed-on: https://code.wireshark.org/review/5057
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
WSUG: Convert ``Customizing'' to AsciiDoc.

Leave most of the content intact for now.

Change-Id: Id00d942f87e0a25e27333ac56eb9b99311694a13
Reviewed-on: https://code.wireshark.org/review/5063
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Add identification of Windows (Server) 10

Change-Id: I5ab7a4dc67ceac644faead0d9e460e3babaf6355
Reviewed-on: https://code.wireshark.org/review/5067
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
DNS: fix Coverity CID 281285 and CID 1238867

Change-Id: Ia5747a5d0c8c63b7471de624c96e546c7bbfbf57
Reviewed-on: https://code.wireshark.org/review/5064
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Eliminate proto_tree_add_text from several dissectors.

Change-Id: I6d3125f15d268edd47ef74dd655eb86cb25ee52d
Reviewed-on: https://code.wireshark.org/review/5047
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
[Automatic manuf, services and enterprise-numbers update for 2014-11-02]

Change-Id: Idc5360a39ab2f2f0b0827bc6c71f95e2f175d792
Reviewed-on: https://code.wireshark.org/review/5073
Reviewed-by: Gerald Combs <gerald@wireshark.org>
lzxpress: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I028d8877a845af5830b17abfe7eb10d8528b334a
Reviewed-on: https://code.wireshark.org/review/5069
Reviewed-by: Anders Broman <a.broman58@gmail.com>
fcels: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I1c351348399caea313abb94680a610073b3e5af7
Reviewed-on: https://code.wireshark.org/review/5070
Reviewed-by: Anders Broman <a.broman58@gmail.com>
gsm a dtap: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: Ifbe59a51e5fa6158f9073402f1a1ab63df2dfa42
Reviewed-on: https://code.wireshark.org/review/5071
Reviewed-by: Anders Broman <a.broman58@gmail.com>
RTPS: fix warning: no previous prototype for function ... [-Wmissing-prototypes]

Change-Id: I1943c1446a7bc3381d869514d7802bc0fbb1f6e3
Reviewed-on: https://code.wireshark.org/review/5072
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Handle PackageMaker a bit better.

Look for the binary in various places, rather than looking for
particular directories and adding them to the path.  That lets us use
the PackageMaker binary from the PackageMaker.app bundle (it can either
be run as a GUI app or from the command line), so you don't have to have
a symlink to it from one of the directories in question.

Change-Id: I1ad701291698544f96d419663f0b4a669876d2f1
Reviewed-on: https://code.wireshark.org/review/5077
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Fix syntax, add a check for failure to find PackageMaker, make sure it's a file.

Change-Id: Id5bb23a8c5ebd8a63a51029de541cd32e484029c
Reviewed-on: https://code.wireshark.org/review/5078
Reviewed-by: Guy Harris <guy@alum.mit.edu>