Looks good initially. I'll take a closer look later.

The only thing that strikes me as a bit strange is that the packages are
part of "eu.stratosphere.core". Can you move them to something like
"eu.stratosphere.fs.tachyon" or "eu.stratosphere.addons.fs.tachyon"? I
personally have a bias towards the first option.


On Wed, Feb 26, 2014 at 7:06 PM, Robert Metzger <notifications@github.com>wrote:

> In stratosphere-addons/tachyon/pom.xml:
>
> > +
> > +    <artifactId>tachyon</artifactId>
> > +    <name>tachyon</name>
> > +
> > +    <packaging>jar</packaging>
> > +
> > +    <dependencies>
> > +        <dependency>
> > +            <groupId>eu.stratosphere</groupId>
> > +            <artifactId>stratosphere-core</artifactId>
> > +            <version>${project.version}</version>
> > +        </dependency>
> > +        <dependency>
> > +            <groupId>org.tachyonproject</groupId>
> > +            <artifactId>tachyon</artifactId>
> > +            <version>0.4.1-SNAPSHOT</version>
>
> I would suggest to use the stable 0.4.0 version of tachyon in maven
> central.
>
> http://search.maven.org/#artifactdetails%7Corg.tachyonproject%7Ctachyon%7C0.4.0%7Cjar
>
> Somehow, our test server is not able to access the SNAPSHOT version ..
> setting the version to one that is available in central will solve the
> problem.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/stratosphere/stratosphere/pull/512/files#r10090966>
> .
>