Fix style for puppet-lint failures.
Use warning instead of notify when inform about deprecation.

Some modules ex. puppet-nova still use $cluster_disk_nodes, and when
notify is used to inform about deprecation every puppet runs cause
rabbitmq server restart.
Make curl and wget not go via a proxy (if one is configured) for installation of the rabbitmq admin CLI
Remove puppet_module_install in favor of copy_module_to
Optimize check for RHEL GPG key

Reduces the time to check for presence of
gpg pubkey for RabbitMQ from 1.6s to 0.1s.
Configure ssl_listener in stomp only for ssl

W/o this patch puppet will always configure
ssl_listener for stomp and rabbitmq service will
fail to start, if ssl => false.

The solution is to ignore ssl_stomp_port in
config_stomp stanza then ssl was not enabled
and issue a puppet warn about that as well.

Closes-bug: #MODULES-1414

Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
Fix missing 'should' in rspecs

W/o this fix, rspec tests will continue
report false positives for many test cases
with config_file involved allowing even
more regressions to be accepted and merged
in master branch.

Fix contains missing 'should' and multiline
regex (/.*/m) statements.

Note: Perhaps, this fix should be merged
despite on CI failure. The failure is natural
for this specific case only, due to multiple
regressions had been accepted while tests
were reporting false positives results.
And in order to fix failing tests later, all
of these regressions should be assdessed by
other patches as well.

Closes-bug: #MODULES-1416

Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
Merge pull request #242 from bogdando/fix_MODULES_1416

Fix missing 'should' in rspecs
Merge pull request #241 from bogdando/fix_MODULES_1414

Configure ssl_listener in stomp only for ssl
Update specs to match content correctly

The specs were discovered in #242 to have never worked, and this PR
updates the tests to match the content of the templates as they
currently stand, assuming that that is the correct format of the config
file.
Merge pull request #243 from hunner/update_specs

Update specs to match content correctly
(MODULES-1411) Puppet 2.7 doesn't have has_command
Update travis.yml to have 2.7
Output cacertfile value only if it is set

When using verify_none cacertfile can be omitted. Therefore no value should be written if it is unset.
Merge pull request #244 from hunner/patch_2.7

(MODULES-1411) Puppet 2.7 doesn't have has_command
use rpm for RedHat family
passing tests
Add key_content parameter for offline install

* Custom key source/content for Debian (apt module) is
  required in order to allow rabbitmq being installed
  by Puppet for intranet only faced hosts as well as
  internet faced ones.
  It also elliminates a hardcode for URL which is a kind of
  SPOF and 'limitation' for operators' freedom of choose.

* Update docs as well

DocImpact
Implements improvement: #MODULES-1408

Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>

Fix package_gpg_key key_source and docs

* Reuse package_gpg_key for apt as well
* Update/add docs for package_gpg_key, key_source
* Fix key_source usage in repo::apt

Signed-off-by: Bogdan Dobrelya <bdobrelia@mirantis.com>
Merge pull request #240 from bogdando/pcs

Add custom key content & service provider support
Use -q flag instead of array slices

Previously we sliced off the informational output lines. This
broke on rabbitmq 3.4.0 because the 'done' was removed. We can use
the -q flag to never print them in the first place.