inline only usage of Array#clump_per

Change-Id: Iaf4c85a6c89e693010e2da3c5830ef496a81ef32
Reviewed-on: https://gerrit.instructure.com/30024
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Raphael Weiner <rweiner@pivotallabs.com>
Product-Review: Raphael Weiner <rweiner@pivotallabs.com>
QA-Review: Raphael Weiner <rweiner@pivotallabs.com>
create summary messages on the user's shard

Change-Id: I35324dac349907031c0737a8eb9f4d2f9444255f
Reviewed-on: https://gerrit.instructure.com/30090
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fix running specs in rails 3 without development gems frd

Change-Id: I25fe977ffaaa2421b6bf1803a473b84e13a0e3e1
Reviewed-on: https://gerrit.instructure.com/30124
Reviewed-by: James Williams  <jamesw@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
fix usage of request.method to work with rails3

refs CNVS-4704

Change-Id: I1edc42653fd76a74fc0cf87b7e99f73aa1274adc
Reviewed-on: https://gerrit.instructure.com/30097
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Jacob Fugal <jacob@instructure.com>
QA-Review: Jacob Fugal <jacob@instructure.com>
converts shared/errors js_block into js_bundle

test plan:
* regression test shared error form (for submitting errors)

Change-Id: Ief28c72f4dd488bb1cbeb795f7a050ad56bf2fe8
Reviewed-on: https://gerrit.instructure.com/29105
Reviewed-by: Jon Jensen <jon@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Jeremy Putnam <jeremyp@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
spec: replace 'should contain' with 'should include' for rails3

Change-Id: Ia77561c179febe5a1bb78576e63151d2dbc09ffe
Reviewed-on: https://gerrit.instructure.com/30115
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
Product-Review: James Williams  <jamesw@instructure.com>
QA-Review: James Williams  <jamesw@instructure.com>
add tooltip to publish button

fixes CNVS-10884

test plan
=========
- with draft state on
- publish an assignment
- have students submit on the assignment
- go to the assignment show page
- when hovering over the publish button, verify that there is a tooltip
  that says "Can't unpublish if there are student submissions."

Change-Id: I42436bc7c09a820c52b2ec079b2bc835c56c8f25
Reviewed-on: https://gerrit.instructure.com/30076
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Liz Abinante <labinante@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Product-Review: Matthew Irish <mirish@instructure.com>
IE10+ TinyMCE Links compatibility

The patch makes linking stuff in the RCE possible on IE10+. The reason
it was not functioning on IE9+ is because the "fix" for IE is installed
only if the browser is identified to be IE, while our detection code was
not able to detect versions past 9.

Closes CNVS-5644

TEST PLAN
---- ----

When I say the link "works" in the steps below, it means 4 things:

  1. the word text is not modified
  2. the word becomes highlighted in blue and underlined as a link
  3. the word stays in its place
  4. the word actually becomes a clickable link (viewable only when
     you're viewing the content as opposed to editing it)

  - create a discussion
  - using Chrome/FF: type some words, then select a word in the middle
    and link it to any web page:
    - verify that the link "works"
  - save the discussion
  - now using IE8, IE9, IE10, and IE11:
    - edit that discussion
    - add another sentence, and link a word in the middle:
      - verify that the link "works"
  - don't hate me

> Optional: embedding YouTube videos

  - enable the YouTube LTI
  - embed a YT vid in the discussion content
  - verify that when you're adding or modifying links using IE, the
    video doesn't disappear or gets broken (as was reported by Caleb)

CR NOTES
-- -----

  - the test for IE10 is done using the conditional JS compiling, which
    is dropped in IE11+
  - the test for IE11 is done by sniffing the UA for Trident and rv:
    11.0
  - in order not to introduce any side-effects, I kept from installing
    an "ie" class on the root document elements in the case of IE10+

Change-Id: I61d6ac1918291eb8df6da1aa270ef8358ed49a8f
Reviewed-on: https://gerrit.instructure.com/29651
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Caleb Guanzon <cguanzon@instructure.com>
Reviewed-by: Josh Simpson <jsimpson@instructure.com>
Product-Review: Ahmad Amireh <ahmad@instructure.com>
log mem/cpu stats for jobs as well

This logs the STAT line in the same format as for web requests, though
omitting the @@last_sample at the end.

Rather than implementing it directly in worker.rb, I pulled in the new
Lifecycle callback code that delayed_job added after we forked, and
added the logging as an around filter in our canvas initializer.
Eventually I'd like to pull the other canvas-specific code into
lifecycle callbacks as well, making delayed_job more generic and
extractable.

test plan: run jobs, and verify that they still complete successfully,
and log a STAT line at the end with information on cpu and memory usage.

Change-Id: I18e17b286f5df8aa3c9774f0ac92841f4b92e193
Reviewed-on: https://gerrit.instructure.com/30037
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
QA-Review: August Thornton <august@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
fix formatting of special ids in api docs

Change-Id: I49499d4dadde3d83ed7b545317723ebad1eae6fd
Reviewed-on: https://gerrit.instructure.com/30101
Reviewed-by: Rob Orton <rob@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
create summary messages on the user's shard

Change-Id: I35324dac349907031c0737a8eb9f4d2f9444255f
Reviewed-on: https://gerrit.instructure.com/30090
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>
inline only usage of Array#to_atom

Change-Id: I5cf6784b4f858f689e8d707dfced29a02590b9ff
Reviewed-on: https://gerrit.instructure.com/30029
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Raphael Weiner <rweiner@pivotallabs.com>
Product-Review: Raphael Weiner <rweiner@pivotallabs.com>
QA-Review: Raphael Weiner <rweiner@pivotallabs.com>
 inline only usage of Array#to_ics

Change-Id: Ife84767f08ba50978e43045054bb9906443c03f3
Reviewed-on: https://gerrit.instructure.com/30030
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Raphael Weiner <rweiner@pivotallabs.com>
Product-Review: Raphael Weiner <rweiner@pivotallabs.com>
QA-Review: Raphael Weiner <rweiner@pivotallabs.com>
revert update of minimum browser support for firefox and safari

test-plan:
* in safari 5, verify browser warning does not display
* in firefox 17, verify browser warning does not display

Change-Id: I15866e476181e76837b15eb749cde52da84e6e52
Reviewed-on: https://gerrit.instructure.com/30062
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
QA-Review: Bryan Madsen <bryan@instructure.com>
spec: bullet test.rb require tweak

Change-Id: Ibe9e0d709e997b6c010c98adfe9e8a4c68bdd7b0
Reviewed-on: https://gerrit.instructure.com/30137
Reviewed-by: Shawn Meredith <shawn@instructure.com>
Product-Review: Shawn Meredith <shawn@instructure.com>
QA-Review: Shawn Meredith <shawn@instructure.com>
Tested-by: Shawn Meredith <shawn@instructure.com>
Updated pt translation
Updated pt translation
capitalizes the o in Feature options

fixes CNVS-10980

 test plan:
    * for the account, course, and profiles settings pages:
    * verify that the feature options tab is title cased.

Change-Id: I9701bd7eeabb1f5e62fc4a5b6da71e549d5f21fd
Reviewed-on: https://gerrit.instructure.com/30025
Tested-by: Mark Severson <markse@instructure.com>
Reviewed-by: Zach Pendleton <zachp@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
add reply messaging to email notifications

fixes CNVS-5793

test plan:
  * set a user's notification settings to ASAP;
  * as another user, do the following and verify that
    the email received contains messaging informing the
    user that they can reply directly to the email:
  * send a conversation message;
  * comment on a discussion topic that the first user is
    subscribed to;
  * comment on one of the user's assignment submissions.

Change-Id: Iffe0763aad26579e5b5955f4f31e5e5242c14355
Reviewed-on: https://gerrit.instructure.com/29504
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Braden Anderson <banderson@instructure.com>
QA-Review: Matt Fairbourn <mfairbourn@instructure.com>
Product-Review: Zach Pendleton <zachp@instructure.com>
fix page view insertions for cassandra on rails 3

Change-Id: Id8a1c3fad26fbd6cf7bb76dbe89e862d0da11540
Reviewed-on: https://gerrit.instructure.com/30106
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
QA-Review: Cody Cutrer <cody@instructure.com>