should take a const std::string&