InlineEdit: Adapt SBS2 to recently made code changes

Ib8281cc2d allowed to edit file content directly from SBS2 in pop up
dialog. Ie9b2c5f2b3 allowed to edit file content directly in SBS2, but
missed to revert previous changes. Clean this up.

Change-Id: I4552cac107ddc61de488aa7bad4f231bfd5e793d
Remove the generateHttpPassword capability

Remove the Generate HTTP Password capability because it exposes a
security vulnerability.  Any user that is granted this capability
can modify an administrator's http password and impersonate the
admin user.  Other reasons for removing this capability are that
the usage of it is inconsistent with the modifyAccount capability
and this capability encourages adding additional capabilities to
restrict permissions, which is not desired.

With this change only administrators are allowed to generate and
delete other users' http passwords.

The motivation behind this change is from comments in changes
Ib1971fad and If8296539.

Change-Id: Id907cc103591eed029fd08af700bb1bb6a618ff8
Update replication plugin to latest revision

- Avoid throwing exception due to deleted change

Change-Id: Ic053278a6145acc4f10b430d08a4c77c7c9c96f2
Avoid CodeReviewCommit.error() whenever possible

The instances returned by this static factory method are severely
limited, in that they are not tied to actual commit objects. In most
cases, we can tie them to commit objects, so do that whenever
possible. Limit the statuses that we can pass to this method by
making it private, and creating separate factories only for those
statuses where there is really no commit.

Change-Id: I0cb392f4f7f5134d4a7487a2a7bb7ac9d770f334
Pass ChangeControl into CodeReviewCommit error instances

Within MergeOp these are keyed by Change.Id, but some error handling
code only receives the CodeReviewCommit and not the ID. That code is
reasonable in assuming there is a change/notes/control available, so
ensure this is the case when creating error instances.

Bug: issue 2911
Change-Id: If65398652f0e5b1a2b10a2fadc9a3b74bce7d556
Update PyDev project to use Python 2.7

Buck now requires Python 2.7, so update the project accordingly.

Change-Id: I5e401b00e9ac80eab3008ced0f632f7d4065fcbf
Add test sources to .classpath files of eclipse plugin projects

Change-Id: I274e7d52648eff78f8cf218b8146bdedac7f8007
Signed-off-by: Stefan Lay <stefan.lay@sap.com>
Close security hole allowing normal user to become admin

Icc105c39e introduced severe security problem, allowing non admin
users that was granted modifyAccount capability to modify SSH keys
of all users, including administrators. But that means such a user
can change the authentication of an existing administrator and then
impersonate the admin to elevate their own account status to that
of an admin.

Rectify it but restricting changing of SSH keys for a user only to
members of administrators group.

Change-Id: If82965391369121b282b969e7072a2bfa3074be9
Mention the push %l-parameter in the documentation

Change-Id: Icc564ca82c2e05d176f75ddfd3b11924dcabaabe
Merge "Mention the push %l-parameter in the documentation"
Clarification of instructions for downloading the commit-msg hook

The instructions are to use one of the example commands to download
the hook.  Separate the example commands into two distinct paragraphs
separated by "or".

Change-Id: I62ee6de6438a392d3ef344652c8dcd9d5f389f97
Move TimeUtil from gerrit-server to gerrit-common

Change-Id: Ib2cfcfd4974ab04e733007e5835fc1364cc36ee9
Remove "deprecation warning" in user upload documentation

Pushing to refs/changes/{number} is not going to be removed, so
it's not appropriate to mention this in a "deprecation warning".

Change the header to "Note" instead.

Change-Id: I7ac522c39481f67859870d3c729bc420837a0441
Consistently use com.google.inject.Inject instead of javax.inject.Inject

JEE containers intercept JSR330 annotations and are failing to deploy
gerrit.war, here example of Wildfly 8: [1]. This change rectifies it
by using consistently Guice's own annotations to prevent it. Here is
fixed deployment on Wildfly [2], note that weld service was started
successfully.

[1] http://paste.openstack.org/show/117008
[2] http://paste.openstack.org/show/117014

Change-Id: Idedd9e44352ced5166b62fa09c4b42971e666aaa
CodeReviewCommit: Add a static method to create a RevWalk

Several places in the code construct a new RevWalk subclass that
produces CodeReviewCommits. Consolidate these into a single method.

Change-Id: If38a648fb95d86f8f8297d1ddacfb9e62a96c8e3
Merge "Consistently use com.google.inject.Inject instead of javax.inject.Inject"
Merge "Add test sources to .classpath files of eclipse plugin projects"
Make Apache Commons IO available for plugin build

Change-Id: I5e16fcb289dcf9c10602c179cf0d49f2a655c8f0
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
SSH: Simplify CachingPublicKeyAuthenticator implementation

In the context of [1] the same class was implemented upstream and since
upgrade to the latest SSHD release is available. So that we don't need
to duplicate the logic, but only supply right authenticator instance
(DatabasePubKeyAuth authenticator in our case) in constructor.

[1] https://issues.apache.org/jira/browse/SSHD-300

Change-Id: I402d4487ce98f030996f7c7f878c564b60ea3dca
Fix using HTTP methods other than GET from plugins

Commit 3bde74c2797 introduced a bug in the REST API. Methods other
than GET could not be used anymore  from plugins. For example it was not
possible anymore to delete projects with the delete-plugin using DELETE.

Bug: issue 2949
Change-Id: If90247ec4e0dad03b02d0a9e21202455fece90a7
Signed-off-by: Stefan Lay <stefan.lay@sap.com>