add proper tests