Hi Bryan,

Yes, this was a missing piece I forgot about (the pass/pass was just a
place-holder for later code I forgot to write altogether).

Fixed with this commit:

https://github.com/ncsaba/python-brlcad/commit/5bdb487d0ded12b43019f7588db396f78de9a08c

It should be now possible to open a file, load a combination/region,
modify and write it back.

Cheers,
Csaba


On Mi, 2014-02-12 at 07:27 -0800, Bryan Bishop wrote:
> In brlcad/primitives/combination.py:
> 
> > -    return SubtractNode(left, right)
> > -
> > -
> > -def xor(*args):
> > -    return XorNode(args)
> > +    def update_params(self, params):
> > +        params.update({
> > +            "db_internal": self.db_internal,
> > +            "directory": self.directory,
> > +            "data": self.data,
> > +            "name": self.name
> > +        })
> > +        if self.is_region:
> > +            pass
> > +        else:
> > +            pass
> 
> What's this pass/pass branching for? Looks the same to me.
> 
> —
> Reply to this email directly or view it on GitHub.
>