Stop pulling in JSCInlines.h all over the place.
<https://webkit.org/b/130105>

JSDOMBinding.h is included by everyone and their uncle, so try to
cut down on the amount of JSC *Inlines.h it includes.

Reviewed by Geoff Garen.

* ForwardingHeaders/heap/SlotVisitorInlines.h: Added.
* ForwardingHeaders/runtime/JSCJSValueInlines.h: Added.
* ForwardingHeaders/runtime/JSCellInlines.h: Added.
* ForwardingHeaders/runtime/StructureInlines.h: Added.
* bindings/js/JSDOMBinding.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Generated hidpi- images (actual) on ML WK2 Debug are blurry/color shifted.

Unreviewed TestExpectations update on ML WK2 debug.

* platform/mac-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add callbacks in WebKit2 Cocoa API for page load testing
https://bugs.webkit.org/show_bug.cgi?id=130569

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(didFirstVisuallyNonEmptyLayoutForFrame):
(didHandleOnloadEventsForFrame):
(setUpPageLoaderClient):
(willSendRequestForFrame):
(didInitiateLoadForResource):
(didFinishLoadForResource):
(didFailLoadForResource):
(setUpResourceLoadClient):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove use of deprecatedCharacters in WebKit API tests
https://bugs.webkit.org/show_bug.cgi?id=130602

Reviewed by Antti Koivisto.

* TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
(TestWebKitAPI::expectEmpty): Use characters8.
(TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.

* TestWebKitAPI/Tests/WTF/StringImpl.cpp:
Removed the test that is entirely about 16-bit conversion since that's basically a test of
the deprecatedCharacters function itself, which we are about to delete.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Rebaseline expectations after r165651.

* platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Replaced Path by Path2D.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Crash in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=129948
<rdar://problem/16074072>
        
Reviewed by Simon Fraser.

Source/WebCore: 

When the marker was placed for multi-column list items, it was being inserted
into the list item itself. Even though the add code in RenderBlock did the right
thing and put the marker inside the multi-column flow thread, the list item code
passed in a beforeChild that was computed using the incorrect parent. This resulted
in the flow thread being used both as the parent of the marker and the sibling of
the marker.
        
The fix is to add some code to RenderListItem to make sure it uses the multi-column
flow thread if it exists both as the parent of the marker and as the basis for the
computation of the sibling that the marker should be placed in front of.

Added fast/multicol/multicol-li-crash.html

* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded):

LayoutTests: 

* fast/multicol/multicol-li-crash-expected.txt: Added.
* fast/multicol/multicol-li-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove unused RenderView::repaintRectangleInViewAndCompositedLayers().
<https://webkit.org/b/130605>

Reviewed by Antti Koivisto.

* rendering/RenderView.cpp:
* rendering/RenderView.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Handle recovery on "timestamp-looking" lines in the WebVTT parser
https://bugs.webkit.org/show_bug.cgi?id=130610

Reviewed by Eric Carlson.

Merged from Blink (patch by fs@opera.com):
https://chromium.googlesource.com/chromium/blink/+/b669a380efbffe25f3b154b026b57b9822ce08e2
http://crbug.com/75273002

Source/WebCore: 

Tests: media/track/track-webvtt-tc031-cue-recovery.html
       media/track/track-webvtt-tc032-degenerate-cues.html

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::parse):
(WebCore::WebVTTParser::collectCueText):
(WebCore::WebVTTParser::recoverCue):
(WebCore::WebVTTParser::ignoreBadCue):
* html/track/WebVTTParser.h:

LayoutTests: 

* media/track/captions-webvtt/tc006-cue-id-error.vtt:
* media/track/captions-webvtt/tc007-cue-no-id-error.vtt:
* media/track/captions-webvtt/tc011-cues-no-separation.vtt:
* media/track/captions-webvtt/tc031-cue-recovery-cuetext.vtt: Added.
* media/track/captions-webvtt/tc031-cue-recovery-header.vtt: Added.
* media/track/captions-webvtt/tc031-cue-recovery-note.vtt: Added.
* media/track/captions-webvtt/tc032-degenerate-cues.vtt: Added.
* media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
* media/track/track-webvtt-tc006-cue-identifiers.html:
* media/track/track-webvtt-tc007-cue-no-id-expected.txt:
* media/track/track-webvtt-tc007-cue-no-id.html:
* media/track/track-webvtt-tc011-blank-lines-expected.txt:
* media/track/track-webvtt-tc011-blank-lines.html:
* media/track/track-webvtt-tc031-cue-recovery-expected.txt: Added.
* media/track/track-webvtt-tc031-cue-recovery.html: Added.
* media/track/track-webvtt-tc032-degenerate-cues-expected.txt: Added.
* media/track/track-webvtt-tc032-degenerate-cues.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
fix-blink-patch: tool to fix up renamed directory paths in Blink
<http://webkit.org/b/130609>

Reviewed by Ryosuke Niwa.

Usage: cat blink.patch | fix-blink-patch | svn-apply

* Scripts/fix-blink-patch: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
unobscuredContentRect() should have the same signature on iOS and other platforms,
and should not recurse on iOS.
https://bugs.webkit.org/show_bug.cgi?id=130604
<rdar://problem/16392587>

Reviewed by Tim Horton and Beth Dakin.

Having different signatures on different platforms is a recipe for
build breakage. Give the iOS unobscuredContentRect() an unused
VisibleContentRectIncludesScrollbars parameter.

Also avoid recursion via unobscuredContentRect() calling visibleContentRectInternal().

* WebCore.exp.in:
* platform/ScrollView.cpp:
(WebCore::ScrollView::unobscuredContentRect):
(WebCore::ScrollView::unobscuredContentRectInternal):
(WebCore::ScrollView::visibleContentRectInternal):
* platform/ScrollView.h:
(WebCore::ScrollView::unobscuredContentRectIncludingScrollbars):
* platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::unobscuredContentRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
ASSERTION FAILED: event == [NSApp currentEvent] hitting Command-+
https://bugs.webkit.org/show_bug.cgi?id=130526
<rdar://problem/16371612> 

This was fixed yesterday for sync code path, landing the same this for async one.

* UIProcess/API/mac/WKView.mm: (-[WKView performKeyEquivalent:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Optimize FEGaussian blur
https://bugs.webkit.org/show_bug.cgi?id=50881

Reviewed by Dirk Schulze.

Currently boxBlur() will calculate the filter for each channel in
a loop and also uses Uint8ClampedArray::set() to write the
resulting pixels into destination array.

Using Uint8ClampedArray::set() requires lots of unnecessary type
conversions, not to mention other function calls. This patch
updates the original written by Simon Fraser to apply cleanly to current
trunk.

It also implements code to handle EdgeModes and finally avoids use
of ::set() in the newly added boxBlurAlphaOnly()
function. Assignment of calculated pixel values rely on pointers.

No new tests, no change on behavior.

* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::boxBlurAlphaOnly): Specialized version for alpha only cases.
(WebCore::boxBlur):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Win] Compile fixes with video not enabled.
https://bugs.webkit.org/show_bug.cgi?id=130597

Patch by Alex Christensen <achristensen@webkit.org> on 2014-03-21
Reviewed by Darin Adler.

Source/WebCore:

* DerivedSources.make:
Only generate UserAgentScripts.h if needed.
* platform/audio/MediaSession.cpp:
* platform/audio/MediaSessionManager.cpp:
Only compile if video is enabled.

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Only include MediaSessionManager symbols if video is enabled.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed WebKitGtk+ rebaseline.

* platform/gtk-wk1/js/dom/global-constructors-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt.
* platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: AXI: Expose Accessibility Tree children of the selected node
https://bugs.webkit.org/show_bug.cgi?id=130264

Patch by James Craig <jcraig@apple.com> on 2014-03-21
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector-protocol/dom/getAccessibilityPropertiesForNode.html

Expose the accessibility tree children (different from DOM children) of the
current node in the accessibility node inspector.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
* inspector/InspectorDOMAgent.h:
* inspector/protocol/DOM.json:

Source/WebInspectorUI:

Expose the accessibility tree children (different from DOM children) of the
current node in the accessibility node inspector.

* Localizations/en.lproj/localizedStrings.js: New "Children" string.
* UserInterface/Base/DOMUtilities.js: Added linkifyAccessibilityNodeReference.
* UserInterface/Models/DOMNode.js: Support for accessibility children.
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js: Support for accessibility children.
* UserInterface/Views/Main.css: New styles for .node-link-list.

LayoutTests:

Updating for support of accessibility tree children.

* inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
* inspector-protocol/dom/getAccessibilityPropertiesForNode.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Replay: replay controller is improperly setting user input bridge state
https://bugs.webkit.org/show_bug.cgi?id=130606

Reviewed by Timothy Hatcher.

The user input bridge was being set based on the old session state,
rather than the new session state.

* replay/ReplayController.cpp:
(WebCore::ReplayController::setSessionState):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Refactor css3/filters/huge-region test
https://bugs.webkit.org/show_bug.cgi?id=129553

Reviewed by Dirk Schulze.

This patch refactors the huge-region to become a big enough
element to *not* be rendered. Plus, adds another test using a huge
blur filter kernel size that will trigger clamping the value to
maximum accepted value (500px).

* TestExpectations:
* css3/filters/huge-blur-value-expected.txt: Added.
* css3/filters/huge-blur-value.html: Copied from LayoutTests/css3/filters/huge-region.html.
* css3/filters/huge-region.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore: Fix a crash when assigning an object to document.location
https://bugs.webkit.org/show_bug.cgi?id=130213

Reviewed by Geoffrey Garen.

Convert location to string before we make use the document.
This prevents us from attempting to navigate a frame that
has already been removed.

Test: fast/dom/navigation-with-sideeffects-crash.html

* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::location):
(WebCore::JSDocument::setLocation):

LayoutTests: Fix semantics of JS execution when assigning an object to document.location
https://bugs.webkit.org/show_bug.cgi?id=130213

Reviewed by Geoffrey Garen.

* fast/dom/navigation-with-sideeffects-expected.txt: Added.
* fast/dom/navigation-with-sideeffects.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Less inclusion of JSCInlines.h.
<https://webkit.org/b/130545>

Stop including JSCInlines.h from JSDOMGlobalObject.h!

Reviewed by Simon Fraser.

* ForwardingHeaders/runtime/IdentifierInlines.h: Added.
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
* bindings/js/JSCommandLineAPIHostCustom.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMStringMapCustom.cpp:
* bindings/js/JSHTMLAllCollectionCustom.cpp:
* bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
* bindings/js/JSLazyEventListener.cpp:
* bindings/js/JSSQLResultSetRowListCustom.cpp:
* bindings/js/JSStorageCustom.cpp:
* bindings/js/ScriptGlobalObject.cpp:
* dom/NodeIterator.cpp:
* dom/TreeWalker.cpp:
* testing/Internals.cpp:
* testing/js/WebCoreTestSupport.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed test fix after r166080.

The cue-timing separator will trigger the creation of a new cue. So this test needs to remove
use of the separator in the cue, so we can read the cue text.

* media/track/captions-webvtt/tc029-timings-whitespace.vtt:
* media/track/track-webvtt-tc029-timings-whitespace.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@166092 268f45cc-cd09-0410-ab3c-d52691b4dbfc