Steven Armstrong [Wed, Jan 15, 2014 at 04:10:47AM -0800]:
> > +path="$(cat "$__object/parameter/path" 2>/dev/null || echo "/$__object_id")"
> > +
> > +if mountpoint -q "$path"; then
> > +   echo yes
> 
> The first user who hits this can submit a patch.

I will take care of this in that case.

Steven Armstrong [Wed, Jan 15, 2014 at 04:12:44AM -0800]:
> > +if mountpoint -q "$path"; then
> > +   echo yes
> > +else
> > +   echo no
> 
> Could do, but seemed more consistent. What I actually would have used is a 'boolean' explorer, but that doesn't work.
> 
> present/absent seemed wrong, as I use that to manage state in /etc/fstab. So it's in addition to state/present/absent did not want to mix/make a mess.

fair enough, just wondering

Steven Armstrong [Wed, Jan 15, 2014 at 04:14:16AM -0800]:
> > +BOOLEAN PARAMETERS
> > +------------------
> > +nofstab::
> > +   do not manage an entry in /etc/fstab
> 
> Could do, but doen't matter eiterway. It's not like it creates a conflict/problem or so.

Imho it creates confusion, if the user expects pass/dump to work when
nofstab is given.

Steven Armstrong [Wed, Jan 15, 2014 at 04:17:58AM -0800]:
> > +remove_block() {
> > +   cat << DONE
> > +tmpfile=\$(mktemp ${file}.cdist.XXXXXXXXXX)
> > +# preserve ownership and permissions of existing file
> 
> tmpfile is a path, not just a file. Would have to split path, add dot to filename, join path ... yuck

good point

-- 
PGP key: 7ED9 F7D3 6B10 81D7 0EC5  5C09 D7DC C8E4 3187 7DF0