Trigger CI: Jvm tools in options

How would this work with the underlying option, whose default value must be
a list of strings (or None)?

Also, why is this necessary? To get rid of BUILD.tools entirely?

On Thu, Dec 18, 2014 at 12:26 PM, John Sirois <notifications@github.com>
wrote:
>
> In src/python/pants/backend/codegen/tasks/antlr_gen.py
> <https://github.com/pantsbuild/pants/pull/878#discussion-diff-22068707>:
>
> > -
> > -  def __init__(self, *args, **kwargs):
> > -    super(AntlrGen, self).__init__(*args, **kwargs)
> > -
> > -    # TODO(John Sirois): kill if not needed by prepare_gen
> > -    self._classpath_by_compiler = {}
> > -
> > -    active_compilers = set(map(lambda t: t.compiler,
> > -                               self.context.targets(predicate=self.is_gentarget)))
> > -    for compiler, tools in self._all_possible_antlr_bootstrap_tools():
> > -      if compiler in active_compilers:
> > -        self.register_jvm_tool(compiler, tools)
> > +  @classmethod
> > +  def register_options(cls, register):
> > +    super(AntlrGen, cls).register_options(register)
> > +    cls.register_jvm_tool(register, 'antlr3', ['//:antlr-3.4'])
>
> Aha - OK. My whole thrust was:
>
> cls.register_jvm_tool(register, 'foo', default_classpath=[JarDependency(...), ...])
>
> If you'll be handling that bit too in a later RB, great; otherwise, I'll
> dust of my AntlrGen tool deps defaulting RB when this all lands.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pantsbuild/pants/pull/878/files#r22068707>.
>