address jshint error flagged by the latest jshint 2.5.6 released yesterday.

Quick notes:
1. this shows up in today's travis run for an unrelated PR.
2. it flags the loop of "for (setting in newConfig) {", so i am fixing it; but since i am on it, I also address other 'for-in' in a safe manner.
3. Looks like loop at #2 actually never gets hit under this context, because it appears "getRoleEnvironmentData" does not really load configuration data. Anyway, I keep the code there. It is relative old code now.
4. We have existing UT there to exercise the code.