CHANGE-709 - Refactor logging infrastructure (continuation)

CHANGE-709 - Refactor logging infrastructure (continuation from earlier changes)
- fix chicken/egg problem with log initialization
- add explicit logging messages in more places
- relocate log-delete code to logwriter
<a href='#crh-start'></a><a href='#crh-data-
I'm not complaining, I'm critiquing.  There's a difference that should not be complained about.

Regardless, that's how private methods are tested. As mentioned before if the tests are too complex, that indicates the class needs refactoring.  Thanks for the effort and updates.



> On Oct 15, 2014, at 11:58 PM, Chris Brown <notifications@github.com> wrote:
> 
> In admin/includes/classes/class.admin.zcObserverLogWriterDatabase.php:
> 
> >    }
> >  
> >    /**
> >     * PCI requires that if the log table is blank, that the logs be initialized
> >     * So this simply tests whether the table has any records, and if not, adds an initialization entry
> >     */
> > -  private function initLogsTable()
> > +  public function initLogsTable()
> Nevertheless, I've rewritten the tests to no longer explicitly test those methods, but rather to test them indirectly by invoking other methods which in turn invoke the private methods. Of course this creates more duplication of (setup) code in tests and slows tests down, but gets around the issues you were complaining about.
> 
> —
> Reply to this email directly or view it on GitHub.