2010-12-24  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        commit-queue should better explain how it will re-open bugs and follow duplicate chains
        https://bugs.webkit.org/show_bug.cgi?id=51549

        I've had multiple people ask me about the commit-queue's behavior
        regarding reporting flaky tests.  I figured it would be best to just
        have the queue explain itself in the bugs it files.

        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Andrei Popescu  <andreip@google.com>

        Unreviewed. Update Chromium test expectations.

        Mark editing/input/ime-composition-clearpreedit.html.html as TEXT.
        This test was added in http://trac.webkit.org/changeset/74605 and
        fails in Chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Return an empty string instead of 'application/octet-stream' in getMIMETypeForExtension()
        https://bugs.webkit.org/show_bug.cgi?id=51457

        WebKit EFL can't play html5 audio because of wrong mime type checking.
        So, 'application/octet-stream' is changed with an empty string.

        * platform/efl/MIMETypeRegistryEfl.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        Returns an empty string instead of application/octet-stream when it can't find proper mime type.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add option to enable Touch Events.
        https://bugs.webkit.org/show_bug.cgi?id=49125

        Add ENABLE_TOUCH_EVENTS option.

        * cmake/OptionsEfl.cmake:
        * cmakeconfig.h.cmake:
2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add option to enable Touch Events.
        https://bugs.webkit.org/show_bug.cgi?id=49125

        Add files for EFL to support TOUCH_EVENTS.

        * CMakeLists.txt:
        * CMakeListsEfl.txt:
        * platform/PlatformTouchEvent.h: Add EFL related constructor.
        * platform/PlatformTouchPoint.h: ditto.
        * platform/efl/PlatformTouchEventEfl.cpp: Added.
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):
        * platform/efl/PlatformTouchPointEfl.cpp: Added.
        (WebCore::PlatformTouchPoint::PlatformTouchPoint):
2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add option to enable Touch Events.
        https://bugs.webkit.org/show_bug.cgi?id=49125

        Implement ewk_frame_feed_touch_event to feed touch events. Because EFL
        doesn't have touch events, Application should generate and pass it.

        * WebCoreSupport/ChromeClientEfl.h:
        (WebCore::ChromeClientEfl::needTouchEvents):
        * ewk/ewk_frame.cpp:
        (ewk_frame_feed_touch_event):
        * ewk/ewk_frame.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Andrei Popescu  <andreip@google.com>

        Unreviewed build fix.

        Add Chromium-mac test expectation for the layout test below.
        [Chromium] http/tests/xmlhttprequest/basic-auth-nopassword.html needs Mac specific test expectations
        https://bugs.webkit.org/show_bug.cgi?id=51589

        * platform/chromium-mac/http/tests/xmlhttprequest/basic-auth-nopassword-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Evan Martin  <evan@chromium.org>

        Reviewed by Darin Adler.

        TextMetrics::width is an integer, but the member is a float
        https://bugs.webkit.org/show_bug.cgi?id=51566

        Change the return type to a float.

        No tests, fixing a compiler warning.
        (I was unable to produce a difference in the values exposed to pages
        with a float versus the previous conversion to an integer.)

        * html/TextMetrics.h:
        (WebCore::TextMetrics::width):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
        https://bugs.webkit.org/show_bug.cgi?id=51576

        * svg/custom/animate-disallowed-use-element-expected.txt: Added.
        * svg/custom/animate-disallowed-use-element.svg: Added.
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Darin Adler.

        setTargetAttributeAnimatedValue should check for a null shadowTreeElement.
        https://bugs.webkit.org/show_bug.cgi?id=51576

        Disallowed elements may be pruned from the shadow tree, leaving a null
        shadowTreeElement. We should check for that before setting attributes.

        Test: svg/custom/animate-disallowed-use-element.svg

        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Maciej Stachowiak.

        Web Inspector: CSS shorthand properties expand unnecessarily
        https://bugs.webkit.org/show_bug.cgi?id=36304

        "border-radius" is a shorthand property that has a "non-standard" format and longhands, see
        http://www.w3.org/TR/css3-background/#border-radius for reference. CSSParser does not use the
        standard parseShorthand() or parse4Values() methods but instead a custom parseBorderRadius() method.
        This method didn't use to create a ShorthandScope instance and set the m_implicitShorthand value
        appropriately when adding implicit longhands, thus they were added as normal properties
        found in the CSS (neither implicit, nor longhands). This is now fixed.

        WebCore:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseBorderRadius):

        LayoutTests:
        * inspector/elements-panel-styles-expected.txt:
        * inspector/resources/elements-panel-styles.css:
        (.foo):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Andreas Kling.

        [chromium] Fix a style nit in the JPEG encoder
        https://bugs.webkit.org/show_bug.cgi?id=51574

        * platform/image-encoders/skia/JPEGImageEncoder.cpp: nit begone.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Kenneth Russell.

        Modify new-run-webkit-tests to shut up and exit when all the threads
        are wedged so that test runs complete faster and we don't end up
        w/ enormous log files.

        https://bugs.webkit.org/show_bug.cgi?id=51572

        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        editing/selection/caret-* tests need rebaseline for gtk
        https://bugs.webkit.org/show_bug.cgi?id=51578

        Rebaseline editing/selection/caret-* tests for gtk.

        * platform/gtk/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/gtk/editing/selection/caret-ltr-2-expected.txt: Added.
        * platform/gtk/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/gtk/editing/selection/caret-ltr-2-left-expected.txt: Added.
        * platform/gtk/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-ltr-expected.png: Added.
        * platform/gtk/editing/selection/caret-ltr-expected.txt: Added.
        * platform/gtk/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/gtk/editing/selection/caret-ltr-right-expected.txt: Added.
        * platform/gtk/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/gtk/editing/selection/caret-rtl-2-left-expected.txt: Added.
        * platform/gtk/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/gtk/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/gtk/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Inline HTML style property out of sync with element.style in Sidebar
        https://bugs.webkit.org/show_bug.cgi?id=51478

        Now the element attribute modifications (including "style") are tracked, which results in the
        source offsets update (in the backend) and Styles/Metrics pane updates (in the frontend)
        on the "style" attribute modification through the Elements tree. Also, it appears that
        a complete "style" attribute removal destroys the inline style declaration
        (StyledElement::m_inlineStyleDecl), while the code used to rely on it being immutable (hence a crash).

        Test: inspector/elements-delete-inline-style.html

        WebCore:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::didModifyDOMAttr):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::didModifyDOMAttr):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
        (WebCore::InspectorStyleSheetForInlineStyle::didModifyElementAttribute):
        (WebCore::InspectorStyleSheetForInlineStyle::text):
        (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
        (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
        * inspector/InspectorStyleSheet.h:
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
        
        LayoutTests:
        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.InspectorTest.addResults):
        (initialize_InspectorTest.InspectorTest.createKeyEvent):
        * inspector/elements-delete-inline-style-expected.txt: Added.
        * inspector/elements-delete-inline-style.html: Added.
        * inspector/elements-tests2.js: Added.
        (initialize_ElementTest.InspectorTest.expandDOMSubtree.processChildren):
        (initialize_ElementTest.InspectorTest.expandDOMSubtree):
        (initialize_ElementTest.InspectorTest.expandDOMSubtreeAndRun):
        (initialize_ElementTest.InspectorTest.nodeForId):
        (initialize_ElementTest.InspectorTest.selectElementAndRun):
        (initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):
        (initialize_ElementTest.InspectorTest.getSelectedElementStyles):
        (initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
        (initialize_ElementTest.InspectorTest.dumpStyleTreeOutline):
        (initialize_ElementTest.InspectorTest.dumpStyleTreeItem):
        (initialize_ElementTest):
        * inspector/styles-add-blank-property.html: Remove unnecessary function.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-23  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Missing Localized Strings
        https://bugs.webkit.org/show_bug.cgi?id=51542

        Added missing strings: "WebSocket",  "Frames", "Text", "Transfer",
        "Preserve Log upon Navigation", and "Go to Line".

        * English.lproj/localizedStrings.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Nikolas Zimmermann.

        SVGElementInstance::m_useElement should be cleared when use element is removed from document
        https://bugs.webkit.org/show_bug.cgi?id=51486

        Test: svg/custom/use-instanceRoot-with-use-removed.svg

        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
        * svg/SVGElementInstance.h:
        (WebCore::SVGElementInstance::clearUseElement):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::removedFromDocument):
        (WebCore::ShadowTreeUpdateBlocker::if):
        (WebCore::SVGUseElement::detachInstance):
        (WebCore::SVGUseElement::detach):
        * svg/SVGUseElement.h:
2010-12-24  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Nikolas Zimmermann.

        SVGElementInstance::m_useElement should be cleared when use element is removed from document
        https://bugs.webkit.org/show_bug.cgi?id=51486

        * svg/custom/use-instanceRoot-with-use-removed-expected.txt: Added.
        * svg/custom/use-instanceRoot-with-use-removed.svg: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Darin Adler.

        inspector/debugger-step-out.html crashing intermittently in the bots
        https://bugs.webkit.org/show_bug.cgi?id=50868

        Use RefPtr rather instead of raw pointers when keeping references
        to refcounted objects.

        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode2):
        (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::create):
        (WebCore::InspectorStyle::InspectorStyle):
        (WebCore::InspectorStyle::buildObjectForStyle):
        (WebCore::InspectorStyle::setPropertyText):
        (WebCore::InspectorStyle::toggleProperty):
        (WebCore::InspectorStyle::styleText):
        (WebCore::InspectorStyle::populateAllProperties):
        (WebCore::InspectorStyle::replacePropertyInStyleText):
        (WebCore::InspectorStyleSheet::create):
        (WebCore::InspectorStyleSheet::InspectorStyleSheet):
        (WebCore::InspectorStyleSheetForInlineStyle::create):
        (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
        (WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
        * inspector/InspectorStyleSheet.h:
        (WebCore::InspectorStyle::cssStyle):
        (WebCore::InspectorStyleSheet::pageStyleSheet):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix compilation on Windows.

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::~InspectorStyle): added explicit empty destructor
        * inspector/InspectorStyleSheet.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
        https://bugs.webkit.org/show_bug.cgi?id=28291

        This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
        We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
        to strings with find in the diff.
        Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/diff_parser.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
        * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
        * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
        * Scripts/webkitpy/tool/steps/validatereviewer.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Screen doesn't be rendered when changing size of EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=43528

        Remove on_resize because ewk_view_fixed_layout_size_set should not be
        called on callback of EVAS_CALLBACK_RESIZE. As it change size of
        FrameView, rendering was ignored when _ewk_view_smart_calculate was
        called.

        * EWebLauncher/main.c:
        (browserCreate):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skip the new editing/input/ime-composition-clearpreedit.html test since textInputController
is unimplemented in the DRT for Windows. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=32021

* platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2010-12-24  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Eric Seidel.

        Clean up CSSRuleData in CSSStyleSelector.h
        https://bugs.webkit.org/show_bug.cgi?id=27753

        Move CSSRuleData and CSSRuleDataList from CSSStyleSelector.h to the .cpp file.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSRuleData::CSSRuleData):
        (WebCore::CSSRuleData::~CSSRuleData):
        (WebCore::CSSRuleData::position):
        (WebCore::CSSRuleData::rule):
        (WebCore::CSSRuleData::selector):
        (WebCore::CSSRuleData::next):
        (WebCore::CSSRuleDataList::CSSRuleDataList):
        (WebCore::CSSRuleDataList::~CSSRuleDataList):
        (WebCore::CSSRuleDataList::first):
        (WebCore::CSSRuleDataList::last):
        (WebCore::CSSRuleDataList::append):
        * css/CSSStyleSelector.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@74642 268f45cc-cd09-0410-ab3c-d52691b4dbfc