The type of the internal data structure for the image_roi is different than
the type passed in to the add_target function. This camera observer is
obviously based on openCV other camera observers may be based on some other
library. I believe it is not up the the base class to define the private
data structures of the derived class. I looked at the other private members
to see if perhaps they should be in the base class. I don't see a need. the
base class just defines the interface.


On Wed, Apr 30, 2014 at 5:51 PM, Shaun Edwards <notifications@github.com>wrote:

> In
> industrial_extrinsic_cal/include/industrial_extrinsic_cal/ros_camera_observer.h:
>
> > +  private:
> > +
> > +    /**
> > +     * @brief name of pattern being looked for
> > +     */
> > +    PatternOption pattern_;
> > +
> > +    /**
> > +     * @brief topic name for image which is input at constructor
> > +     */
> > +    std::string image_topic_;
> > +
> > +    /**
> > +     *  @brief cropped image based on original image and region of interest
> > +     */
> > +    cv::Mat image_roi_;
>
> Is the image ROI really specific to a ROS camera observer. It seems like
> this would be in the base class (i.e. for all implementations). There are
> other member variables in this file that fall under this observation as
> well.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ros-industrial/industrial_calibration/pull/26/files#r12170236>
> .
>