started to implement attributes