Security Group ICMP validation for icmp-code

This patch would ensure that Security Group rule creation would
fail when icmp-code alone is provided.

Partially implements: bp ipv6-api-testing-parity
Change-Id: Ib630a72b0979c9738c80cbb0df862bab10b30e5c
Add a shelve/unshelve scenario

Current test of shelve/unshelve in api/compute/servers/test_server_actions
only checks the API. Nova Bug #1257594 shows that shelve was once not
reliable. This addition should prevent this bug from ever coming back.

Change-Id: Ie9c28e0f17e25f75ce435ac574244cd3c3c69c9a
Moved init_conf call and preserve tempest network objects

Fixes race condition where configuation is accessed
before it is configured.

Preserve ports and subnets for tempest.conf networks.

Devstack creates private and public networks, and ports
and subnets in these networks. Cleanup needs to preserve
these objects unless --delete-tempest-conf-objects flag
is used.

Also removed unnecessary argument and updated doc string.

Change-Id: I30381191fde36aa71639a4aac3a4ca18a0733052
Add Conflict exception in test_floating_ips_actions case

We modify the error return code in nova api both v2 and v2.1, so we need to
reflect this to tempest test cases test_associate_already_associated_floating_ip
changes : add HTTPConflict

Nove review link: https://review.openstack.org/#/c/127889/

Change-Id: Icbb7b0aa46c864993290749e9a6711f3fa224255
Sync latest log module from oslo-incubator

This commit syncs the latest version of the log module oslo-incubator.
Depends-On: Iee20319e7596232de5bed5b9755381ead44e3f46
Closes-Bug: #1386530
Change-Id: Ibc6fde39f93dd620f8e6020129aa7c10d12b581f
enable cinder v2 api for test_volumes_backup

Partially implements: blueprint cinder-v2-api-tests

Change-Id: Ib091928b3f6ed8ffd54b0a8e35f167a8ceb52560
Security Groups  API Tests Enhancements

Add test to create security  rule
    -Create a security group rule with protocol attribute as integer value
    -Validate the security rule protocol value

Change-Id: Icd967f8d25a55c3e0db57af8e764bfb0a3dab6f9
Added neutron cli test case for fwaas

Change-Id: I43bcbae0ad5a6379b7f93c82c7a330ca7de8a6bd
Use standard assertVolumeStatusWait for volume detachment

Custom volume state detection method in test_compute_with_volumes
is unreasonable for volume detachment. Because in contrast to
volume attachment the target volume state ('available') is set when
all detachment processes have been finished.

Change-Id: I6d3d1186e73175fb25e2204088866cf53f61f4d5
Related-Bug: #1355285
Fix error message when isolated tenant subnet creation fails

The current code assumes that setting the message of an exception will
cause the desired message to be displayed but this does not appear to be true.

Change-Id: I7e91179e7cb426645e9250671d3b54475f79a613
Updated from global requirements

Change-Id: I6b35f578bacead0cfe04ac21e36c50294ad5671b
Update documentation for clarity

Fixes bug #1393908

Change-Id: Iec46949f9f4beb25d6818b6b141de78180630a60
Unified interface for ScenarioTest and NetworkScenarioTest

Allows scenarios to use similar methods for Floating IP and network checks
regardless of network implementation done by Nova/Neutron

Creates floating IP helpers for Nova clients

Moves connectivity check helpers to manager.ScenarioTest to be used with both
classes

Change-Id: Id6a9feb7bcab811a5b5d4985397c419c02b4269a
Take InstanceType for launchconfig res creation

Take the init value of InstanceType for launchconfig
resource creation, since heat will apply nova flavor
custom constraint for launchconfig resource,
see: https://review.openstack.org/#/c/134879/

Change-Id: I23c6032f49104880dc6b424d115ff437f698f5c6
Merge "Add Conflict exception in test_floating_ips_actions case"
Merge "Update documentation for clarity"
Cleanup class resources for large-ops scenario

Large Ops scenario is design to test the bulk creation of VMs while multiple
VMs already exist in tenant.
Due to some refactoring in Tempest scenario, the VMs are now deleted at the end
of the individual test cases.

Removes usage of addCleanup() from large-ops scenario.

Adds Class level method - addCleanupClass to cleanup resources at the end of
the test class.

Closes-Bug: #1395759
Change-Id: I612fcfab83a2046b8e597e009e385d7918f943b9
rm pyc files before test runs

It's extremely easy for incorrect local results to happen if a file
has been moved or deleted in an upstream pull. Add the rm pyc cantrip
to ensure local testing matches what a clean upstream is going to be
like as much as possible.

Change-Id: Iecf18d7c2310918ec90c14c64cd3083e46459980
Merge "Use standard assertVolumeStatusWait for volume detachment"
Merge "Sync latest log module from oslo-incubator"