On 29/04/2014 17:06, Vincent Zurczak wrote:
>
> In 
> roboconf-agent/src/main/java/net/roboconf/agent/internal/AgentUtils.java:
>
> > @@ -236,7 +249,30 @@ private static String getSpecificAttributeOfTagInXMLFile(String filePath, String
> >  	    }
> >  	    return attrValue;
> >  	}
> > -	
> > +
> > +	/**
> > +	 * Check IP address syntax (basic check, not exhaustive)
> > +	 * @param ip The IP to check
> > +	 * @return true if ip looks like an IP address, false otherwise
> > +	 */
> > +	private static boolean isValidIP(String ip) {
>
> There may be shorter.
> See 
> http://stackoverflow.com/questions/5667371/validate-ipv4-address-in-java
>
> return ip != null && ip.matches( IP_PATTERN );
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/roboconf/roboconf/pull/65/files#r12097824>.
>
Yes, I know, I saw dozens of these. An prefered one that is 
understandable by real humans (not even sure it is slower than matching 
that kind of unforgettable patterns ;)