Revert "Fixing neutron::server deprecated warnings"

This reverts commit b799640d219b42955165bd81acde5b32ee0f99f9.

Change-Id: I978cd75b8264e1b5234fc930d4488fff513fe53e
Fixing neutron::server connection parameter

Previously, neutron::server's (deprecated) sql_connection parameter
had a default value, preventing the new/preferred connection
parameter from ever being used.

This change removes that default, permitting the connection
parameter to work properly, and extends unit tests to confirm.

bug introduced at commit 82552e79316a4ffc1c879dd3aaa1f4735a4a35a0,
change I300fc12092bca1abdd105e0c0c272f7fd49258ac

Change-Id: I116b482c620b5c44b88c1b801438a100343f6f9f
(cherry picked from commit af1fd0b6042c76fc48bae81d36a74b7a51d00fb7)
Tune up report and downtime intervals for l2 agent

If the neutron server erroneously thinks than the l2 agent is down
it will fail to bind a port, which can lead to VM's spawn errors.

This patch aims to add support for agent checks flags.

Change-Id: If047c5d52d10a8ca9b1b765400bdd99a29550b1e
Signed-off-by: Emilien Macchi <emilien.macchi@enovance.com>
(cherry picked from commit 30885efc1f7ee1b8490474399014f1f5c931097f)
Merge "Revert "Fixing neutron::server deprecated warnings"" into stable/havana
Merge "Fixing neutron::server connection parameter" into stable/havana
Merge "Tune up report and downtime intervals for l2 agent" into stable/havana
Fix improper test for tunnel_types param

When VXLAN support was added to the ovs agent manifest, a new
parameter called tunnel_types was also added with the default
value being an empty array.  However, later in the code there's
an if loop that tests truth--and an empty array returns true.
This causes a line of the form:

tunnel_types =

to show up in /etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini
if the default value is used, which causes OVS to refuse to start.
This patch corrects the problem by properly testing the array.

Change-Id: I06ad6249ab7803676e49c026b4692f06ade269ed
Closes-Bug: #1281684
(cherry picked from commit f3a4b53a417db64ed7c26980893a4a8e3ccde83c)
Merge branch 'stable/havana' of https://github.com/stackforge/puppet-neutron into havana