oo-diagnostics: Fix test_node_mco_log when no log

Make test_node_mco_log fail gracefully when the node mcollective log file
is absent.  Before this commit, the test would hang because it would run
a sed command with no input file provided.

This commit fixes bug 1077664.
oo-diagnostics: Drop unneeded require 'socket'

Drop a "require 'socket'" statement in the test_broker_certificate check.

This require statement was obviated in commit
9b72939f28a6d35354db74cc7464d879bbd3a81e.
oo-diagnostics: Better handle curl error

Catch and report if curl returns an error in the test_broker_certificate
check.

Previously, test_broker_certificate would ignore curl's return code, and so
errors connecting to the broker would turn up as backtraces when
test_broker_certificate would try to parse the output from curl.
oo-diagnostics: Fix comments for test_node_mco_log

Place comments with relevant code, consistently use proper case and
punctuation, and use whitespace for better logical grouping.
Merge pull request #4983 from Miciah/bug-1077664-oo-diagnostics-test_node_mco_log-fixes

Merged by openshift-bot
Use the local1 facility for Syslog trace logs

Allow trace log segregation by logging trace messages using the local1
facility.

Resolve bug: https://bugzilla.redhat.com/show_bug.cgi?id=1097745
Merge pull request #5414 from ironcladlou/syslog-facility

Merged by openshift-bot
Merge pull request #5324 from Miciah/oo-diagnostics-test_broker_certificate-fixes

Merged by openshift-bot