Follow-up to r1606840: Update another svnadmin verify check.

* subversion/tests/cmdline/svnadmin_tests.py
  (verify_keep_going): Expect separate output for repos with low-level
                       checksum checks vs. those without. 

* subversion/tests/cmdline/svntest/verify.py
  (RegexListOutput.extend): Add trivial new method.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1606902 13f79535-47bb-0310-9956-ffa450edef68
Following up on r1485488, remove unneeded && expression which is already part
of the loop condition.

* subversion/libsvn_diff/diff_file.c
  (find_identical_suffix): Remove unnecessary operation.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607063 13f79535-47bb-0310-9956-ffa450edef68
Remove an unused argument from a static function.

* subversion/libsvn_diff/diff_file.c
  (read_chunk): Remove unused path argument.

  (increment_chunk,
   decrement_chunk,
   find_identical_suffix,
   datasources_open,
   datasource_get_next_token,
   token_compare): Update caller.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607070 13f79535-47bb-0310-9956-ffa450edef68
* subversion/libsvn_diff/lcs.c
  (svn_diff__lcs): Following up on r1128857, replace tab with 4 spaces.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607075 13f79535-47bb-0310-9956-ffa450edef68
Replace a few more tab characters with spaces. No functional changes.

* subversion/libsvn_client/prop_commands.c
  (svn_client_revprop_set2):

* subversion/libsvn_delta/xdelta.c
  (block):

* subversion/libsvn_fs_fs/dag.c
  (svn_fs_fs__dag_serialize):

* subversion/libsvn_fs_x/dag.c
  (svn_fs_x__dag_serialize):

* subversion/libsvn_ra_serf/commit.c
  (proppatch_walker):

* subversion/libsvn_subr/utf_width.c
  (mk_wcwidth):

* subversion/libsvn_wc/questions.c
  (compare_and_verify):

* subversion/tests/cmdline/atomic-ra-revprop-change.c
  (change_rev_prop): Replace tabs with spaces.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607085 13f79535-47bb-0310-9956-ffa450edef68
* subversion/libsvn_ra_serf/commit.c
  (abort_edit): Clear arctivity and txn url, to avoid deleting a txn
    twice if a buggy caller calls abort twice.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607104 13f79535-47bb-0310-9956-ffa450edef68
Remove code duplication.

* subversion/libsvn_ra_svn/client.c
  (ra_svn_open): Switch to dual-pool and ...
  (ra_svn_open_pool): ... add a single-pool wrapper.
  (ra_svn_dup_session): Call ra_svn_open instead of duplicating code.
  (ra_svn_vtable): Use single-pool wrapper.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607212 13f79535-47bb-0310-9956-ffa450edef68
Avoid a theoretical case where we call editor->abort_edit() twice.
(Only triggerable by an import, which imported nothing... where the
 first abort fails)

Found by: ivan

* subversion/libsvn_client/import.c
  (import_ctx_t): Remove TODO comment that describes implementation that
    doesn't follow current best practices.
  (import): Add output argument describing whether we committed something.
    Allocate import_ctx on the stack. Remove abort on no-change.
  (svn_client_import5): Use new information to determine when to abort.
    Always destroy iterpool.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607299 13f79535-47bb-0310-9956-ffa450edef68
Eliminate FSFS format 7 CPU overhead from svnadmin.

This introduces a simply threshold value for the cache sizes above
which we will enable block-read.

While svnadmin is the ideal application for "block-read" (read all
repo data somewhat linearly and use virtually all of it), the very
small default cache sizes are simply not enough to benefit from it.
As a result, hit rates drop even further.

For larger caches, the feature equalizes most of the structural
disadvantage that packed f7 repos have over f6 (f6 is in revision
order and svnadmin is the only tool to read it in that ordering).
For smaller caches, only meta data and certain temporary objects
get cache while we heavily rely on the OS disk cache to provide
us with data.  This is equally true for all FSFS formats.

* subversion/svnadmin/svnadmin.c
  (BLOCK_READ_CACHE_THRESHOLD): Declare and document the new threshold.
  (open_repos): Set the FS config option for "block-read" depending
                on the configured membuffer cache sizes.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607306 13f79535-47bb-0310-9956-ffa450edef68
Organize the contents of svn_repos.h for clarity, especially with regard to grouping
of declarations for the Doxygen documentation. Update some doc strings.

(A cherry-pick merge of r1607334 from the move-tracking-2 branch where I
accidentally committed it first.)

* subversion/include/svn_repos.h
  (svn_repos_load_uuid): Move into the 'svn_repos_dump_load' group.
  (svn_repos_authz_func_t): Tweak doc string, as it's now widely used.
  (svn_repos_file_rev_handler_t): Move adjacent to where it is used.
  (svn_repos_remember_client_capabilities): Move adjacent to the repository
    capabilities group.
  (svn_repos_fs_change_node_prop): Update documentation about what exactly
    is validated.
  (svn_repos_fs_get_inherited_props): Move into the properties group.
  Add new Doxygen groupings around existing groups of declarations:
  'svn_repos_authz_callbacks', 'svn_repos_notifications',
  'svn_repos_capabilities', 'svn_repos_properties'.
  In the 'svn_repos_dump_load' group, mention verifying as well.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607346 13f79535-47bb-0310-9956-ffa450edef68
* subversion/include/svn_repos.h
  Remove an ancient (pre-1.0) speculative comment.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607349 13f79535-47bb-0310-9956-ffa450edef68
Revert r1606902. This fixes the regression tests.

The original change had been made for a feature that is
now disabled in the svnadmin default config.

git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607377 13f79535-47bb-0310-9956-ffa450edef68
Fixed some compiler warnings.

* subversion/libsvn_diff/binary_diff.c
  (write_literal): Change the type of a local variable to avoid
   a 64-to-32-bit conversion warning on 64-bit platforms.
* subversion/libsvn_subr/cache-membuffer.c
  (svn_membuffer_get_segment_info): Likewise.
* subversion/libsvn_fs_base/bdb/strings-table.c
  (svn_fs_bdb__string_read): Add a cast to avoid a 64-to-32-bit
   conversion warning on 64-bit platforms.
* subversion/libsvn_fs_fs/rev_file.c
  (set_read_only): Initialize the status because it may have
   been used uninitialized.
* subversion/svn/merge-cmd.c
  (unspecified_revision): Remove unused global variable.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1607572 13f79535-47bb-0310-9956-ffa450edef68
* subversion/svnserve/serve.c
  (unlock_many): Initialise variable in case unlock returns zero tokens.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1608451 13f79535-47bb-0310-9956-ffa450edef68
In ra-serf, don't declare xml attributes which are never used in the dav
protocol.

* subversion/libsvn_ra_serf/update.c
  (update_ttable): Don't define rev as valid property for add-file/-dir
    as they don't use this. Don't declare the unused bc-url for files, as
    it is only provided on dirs.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1608742 13f79535-47bb-0310-9956-ffa450edef68
Simplify a bit of logic. No functional changes.

* subversion/mod_dav_svn/reports/update.c
  (add_helper): Move bc_url string calculation to the directory case.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1608745 13f79535-47bb-0310-9956-ffa450edef68
* subversion/libsvn_client/import.c
  (svn_client_import5): Pass valid pool in abort_edit() call.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1608816 13f79535-47bb-0310-9956-ffa450edef68
Do not run the C tests when testing ra_svn or ra_serf.

* build/run_tests.py
  (TestHarness.__init__): Check if we're using the file:// protocol.
  (TestHarness.run): Filter the C tests out of the test list if we're not
   testing ra_local.
  (TestHarness._split_nums): New; code hoisted out of TestHarness._run_test.
  (TestHarness._run_test): Use TestHarness._split_nums.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1609477 13f79535-47bb-0310-9956-ffa450edef68
Fix fallout from r1609477.

* build/run_tests.py
  (TestHarness.__init__): Don't assume that the base URL is set.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1609484 13f79535-47bb-0310-9956-ffa450edef68
Follow-up to r1609477: Make skipping the C tests optional for any RA method.

* Makefile.in (check): Interpret the SKIP_C_TESTS option.
* build/run_tests.py
  (TestHarness.__init__): Accept a new optional parameter skip_c_tests
   and initialize the object attribute from it.
  (main): Add new options --skip-c-tests and synonym --skip-C-tests.
   Defaults to false; pass the value to the TestHarness constructor.


git-svn-id: https://svn.apache.org/repos/asf/subversion/trunk@1609489 13f79535-47bb-0310-9956-ffa450edef68