Revert [29267], as it causes unit test breakage and appears unnecessary. see #28986.


git-svn-id: https://develop.svn.wordpress.org/trunk@29274 602fd350-edb4-49c9-b593-d223f7449a82
Fix a typo in the PHPDoc for `get_stylesheet()`.

Props lgedeon.
Fixes #28985.


git-svn-id: https://develop.svn.wordpress.org/trunk@29275 602fd350-edb4-49c9-b593-d223f7449a82
Fix a typo in the PHPDoc for `wp_register_sidebar_widget()`.

Props Jonnyauk.
Fixes #29007.


git-svn-id: https://develop.svn.wordpress.org/trunk@29276 602fd350-edb4-49c9-b593-d223f7449a82
After [29179], remove the last instance of `this.isCompatibleSrc()`.

Props kovshenin.
See #28905.



git-svn-id: https://develop.svn.wordpress.org/trunk@29277 602fd350-edb4-49c9-b593-d223f7449a82
Add support for `attachment_fields_to_edit` in the attachment details modal. props ericlewis. fixes #28991, see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29278 602fd350-edb4-49c9-b593-d223f7449a82
Editor scrolling:
- Improve TinyMCE resizing when a floated block is at the end of the content.
- Improve setting the padding/margin under the toolbar on loading.
- Add custom event on TinyMCE resizing and use it to adjust the pinning (if needed).
Part props avryl, see #28328.

git-svn-id: https://develop.svn.wordpress.org/trunk@29279 602fd350-edb4-49c9-b593-d223f7449a82
Media Grid: Remove fields from showing in the grid itself.

All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.


git-svn-id: https://develop.svn.wordpress.org/trunk@29280 602fd350-edb4-49c9-b593-d223f7449a82
Set default values for attachment meta and ID3 data when preparing for JS to avoid errors in rendering templates. props ericmann for the initial patch. fixes #29013.


git-svn-id: https://develop.svn.wordpress.org/trunk@29281 602fd350-edb4-49c9-b593-d223f7449a82
Media Grid: Manage focus when toggling between the grid and an edit attachment modal

Props adamsilverstein for the initial patch.
Fixes #28857.


git-svn-id: https://develop.svn.wordpress.org/trunk@29282 602fd350-edb4-49c9-b593-d223f7449a82
The Underscore templates for Gallery settings should respect defaults when marking an `<option>` as `selected`.

See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@29283 602fd350-edb4-49c9-b593-d223f7449a82
When gallery settings are overridden, the JS-generated shortcodes need to check the new defaults before deleting attributes that it suspects are the same as the original default values.

`wp.media.collection` has a new method to do this: `setDefaults()`.	Also flips the use of `_.extend` to allow this method to be overriden on instance creation.

See #28693.


git-svn-id: https://develop.svn.wordpress.org/trunk@29284 602fd350-edb4-49c9-b593-d223f7449a82
Don't render Attachment Display Settings when `display` is set to `false`. Currently, the value for `display` in the `media.view.AttachmentsBrowser` instance in the `media.view.MediaFrame.Select` frame is set to the value for `displaySettings`. 
These values do different things, so check for the existence of `display` on the state before arbitrarily setting it to the `displaySettings` value.

Real world: this hides display settings when you select an image while editing a Gallery.

Fixes #28653.


git-svn-id: https://develop.svn.wordpress.org/trunk@29285 602fd350-edb4-49c9-b593-d223f7449a82
Remove white box-shadow divider from uploading status area for consistency.

Props paulwilde.
Fixes #28751.


git-svn-id: https://develop.svn.wordpress.org/trunk@29286 602fd350-edb4-49c9-b593-d223f7449a82
Media Grid CSS: Media modal close icon should be consistent with other modals.

Props celloexpressions.
Fixes #29012.


git-svn-id: https://develop.svn.wordpress.org/trunk@29287 602fd350-edb4-49c9-b593-d223f7449a82
Media Grid: remove pencil icon from attachment hover and a bunch of unused CSS.

Fixes #28945.


git-svn-id: https://develop.svn.wordpress.org/trunk@29288 602fd350-edb4-49c9-b593-d223f7449a82
Media Grid: UI improvements to Attachment modal.

Props ryelle.
See #28844.


git-svn-id: https://develop.svn.wordpress.org/trunk@29289 602fd350-edb4-49c9-b593-d223f7449a82
In `sanitize_file_name()`, replace `%20` and `+` with dashes. Remove unnecessary code from `_wp_handle_upload()`.

Adds unit tests.

Props ericmann.
Fixes #16330.


git-svn-id: https://develop.svn.wordpress.org/trunk@29290 602fd350-edb4-49c9-b593-d223f7449a82
Add exif `orientation` to data extracted in `wp_read_image_metadata()`.

Props shanebp.
Fixes 28916.


git-svn-id: https://develop.svn.wordpress.org/trunk@29291 602fd350-edb4-49c9-b593-d223f7449a82
Whitelist `input` types that are styled in the scope of `.form-field`.

Props mauteri.
Fixes #28647.


git-svn-id: https://develop.svn.wordpress.org/trunk@29292 602fd350-edb4-49c9-b593-d223f7449a82
Correct a few `@param` docs for `$walker`.

Props dnaber-de.
Fixes #29011.


git-svn-id: https://develop.svn.wordpress.org/trunk@29293 602fd350-edb4-49c9-b593-d223f7449a82