Is it in scope, you mean?

Well, I think as long as it's a performance benefit that doesn't affect the way developers interface with the polyfill and doesn't add much code, then yes it's fine. Similar to caching a lookup temporarily.

Is that what you mean?



On Mar 26, 2014, at 12:09 PM, Markus Staab <notifications@github.com> wrote:

> In src/picturefill.js:
> 
> >          // Loop through all images on the page that are `<picture>`
> >          var pictures = doc.getElementsByTagName("picture");
> >          for (var i=0, plen = pictures.length; i < plen; i++) {
> >              var picture = pictures[i];
> > +
> > +            // if a picture element has already been evaluated, skip it
> > +            // unless "forceEvaluate" is set to true (this, for example,
> > +            // is set to true when running `picturefill` on `resize`).
> > +            if (picture.hasAttribute('data-evaluated') && !forceEvaluate) {
> > +                continue;
> > +            };
> @scottjehl just spotted some more of those, e.g.
> https://github.com/scottjehl/picturefill/pull/139/files#diff-e3cc12fee32d40e95863f7b6bee3e282L143
> 
> is this part of the projects' CS?
> 
> —
> Reply to this email directly or view it on GitHub.
>