chore(markdown): Removed old static markdown library in favor of compose...

...r version. Deprecated old Markdown function.
Agreed. Our principle is "don't rely on elgg core's deps"

On Mon, Dec 22, 2014, 8:01 AM Steve Clay <notifications@github.com> wrote:

> In engine/lib/deprecated-1.10.php
> <https://github.com/Elgg/Elgg/pull/7717#discussion-diff-22174267>:
>
> > @@ -53,3 +53,14 @@ function generate_user_password(\ElggUser $user, $password) {
> >  	elgg_deprecated_notice(__FUNCTION__ . " is deprecated and will not be replaced.", "1.10");
> >  	return _elgg_services()->passwords->generateLegacyHash($user, $password);
> >  }
> > +
> > +
> > +/**
> > + * Convert Markdown to HTML.
> > + *
> > + * @deprecated 1.10 Use \Michelf\MarkdownExtra::defaultTransform instead
>
> Not sure I want to tell devs to rely on this. I'd prefer two other options:
>
>    1. Add elgg_markdown() as a wrapper available to plugin devs.
>    2. Tell devs they must provide their own Markdown implementation if
>    they need it elsewhere.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Elgg/Elgg/pull/7717/files#r22174267>.
>