Fixes messages logged on Glance plugin retries

Retry logic is now being used for both upload_vhd and download_vhd,
but nova/virt/xenapi/client/session.py still had 'upload_vhd'
hardcoded in its logged messages. This change causes it to accept the
function being used as an argument and display that.

Fixes-Bug: #1265054
Change-Id: I6203aef81960078f92fa7839e47ee1c84df95745
Add return value to some network API methods

Add return value to api methods add_fixed_ip_to_instance() and
remove_fixed_ip_from_instance(). This allows the @refresh_cache
decorator to use returned nw_info model for updating instance
info cache instead of needing to make another rpc call to get
that same information.

Tests are added to make sure return values are used by the
refresh_cache decorator for methods where the rpc call returns
with the necessary nw_info model.

Change-Id: I748e4db9de62d82e4dbcb0b9c444b16dabf0ec5d
Partial-Bug: #1284345
Fix description of ServerGroupAffinityFilter

ServerGroupAffinityFilter was used instead of
ServerGroupAntiAffinityFilter in the filter description.

Change-Id: I16721db5a7dcf90e72047dd5ca5a4f55088c147d
Add tests for remaining expected conductor exceptions

This fills out coverage of our expected exceptions on conductor
methods, which helps ensure we don't drop an expected exception
class during a refactor.

Change-Id: Iacd5315d47ad97c8aad43d2f6a23674529775e63
Fix anti-affinity server-group boot failure

When the second instance is booted to an anti-affinity group
the scheduler fails with an exception due to a missing type conversion.

Closes-Bug: #1301982
Change-Id: I87b2a8d8c7d04b781c789374d6e9c7f4c8567e5d
Revert "Use debug level logging during unit tests"

This change made the subunit_log 190 MB on every run (14MB
in the gz version). It also dramatically increases the
memory needed to run unit tests. We need to revert and
come at this problem with fresh eyes to address the problem
at hand without effectively overrunning people's environments.

This reverts commit f9090b0bd796f8c2fdf8d0a23173f3adee71b3df.

Change-Id: Ia1cfc3d874ddf4f8ee2037b487d22f968585854e
Update docs to reflect new default filters

Server group scheduler filters were added to the default set of
scheduler filters.  Update the docs to reflect the updated defaults.

Change-Id: I614cf83e419c93038fc4ed7287ec743cedb4860e
Related-bug: #1303983
Correct test boundary for libvirt_driver.get_info

The test_get_domain_info_with_more_return() unit test was causing
failure on some systems where lxml was not capable of handling None for
the xml to parse. However, our unit tests should not be testing libvirt;
the unit tests in libvirt already do that. Our unit tests should simply
test the code boundaries of the unit of code that they wish to stress,
and not anything further.

This patch changes the unit test in question to only test the code
within the libvirt_driver.LibvirtDriver.get_info() method, and nothing
more, and in doing so, we remove any calls at all to libvirt and mock
out where the code passes the boundaries of the get_info() method.

Change-Id: I022cc331a980c2a4d98f16d2d77b24839b528464
Closes-bug: #1301602
Merge "Revert "Use debug level logging during unit tests""
Merge "Fix description of ServerGroupAffinityFilter"
Merge "Correct test boundary for libvirt_driver.get_info"
Merge "Add return value to some network API methods"
Merge "Fix anti-affinity server-group boot failure"
Merge "Update docs to reflect new default filters"
Merge "Fixes messages logged on Glance plugin retries"
Merge "Add tests for remaining expected conductor exceptions"