Rewrite raw memcard threading code. Intended to fix issue 7484.

I do, I'm just saying that if it ever existed (I don't remember anything
like that, but again I wasn't working on the project before 2012-ish), this
policy was strongly misled.

I find this as stupid as you do and I'm just waiting for enough people to
be annoyed by it and switch to spaces indentation in the whole project.


On Sun, Aug 10, 2014 at 11:14 PM, shuffle2 <notifications@github.com> wrote:

> In Source/Core/Core/HW/GCMemcardDirectory.h:
>
> > @@ -13,15 +13,17 @@ void MigrateFromMemcardFile(std::string strDirectoryName, int card_index);
> >  class GCMemcardDirectory : public MemoryCardBase, NonCopyable
> >  {
> >  public:
> > -	GCMemcardDirectory(std::string directory, int slot = 0, u16 sizeMb = MemCard2043Mb, bool ascii = true,
> > -		DiscIO::IVolume::ECountry  card_region = DiscIO::IVolume::COUNTRY_EUROPE, int gameId = 0);
> > -	~GCMemcardDirectory() { Flush(true); }
> > -	void Flush(bool exiting = false) override;
> > +	GCMemcardDirectory(std::string directory, int slot = 0,
> > +					   u16 sizeMb = MemCard2043Mb, bool ascii = true,
>
> I am reasonably sure you understand my point.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dolphin-emu/dolphin/pull/778/files#r16038582>.
>



-- 
Pierre "delroth" Bourdon <delroth@gmail.com>
Software Engineer @ Zürich, Switzerland
http://code.delroth.net/