I shouldn't be trusting Vim's fix indent that much. Thanks for the heads up.

As for the breaks, I'll digg into it and see what is correct way.
I thought that return makes break unnecessary, but I've been wrong before :)

--- Original Message ---

From: "Jerad Bitner" <notifications@github.com>
Sent: February 16, 2014 4:31 AM
To: "sirkitree/bot_jira" <bot_jira@noreply.github.com>
Cc: "Bill Seremetis" <bill@seremetis.net>
Subject: Re: [bot_jira] Some very simple modifications (#1)

> @@ -21,6 +22,21 @@ function bot_jira_menu() {
>    return $items;
>  }
>
> +/**
> + * Implements hook_help().
> + */
> +function bot_jira_help($path, $arg) {
> +  switch ($path) {
> +  case 'irc:features':

each `case` under a `switch` should be indented two more spaces (as well as what is within the `case`). Each `case` should also have a `break;` but since you're returning right from the `case` I think this is okay with out them.

---
Reply to this email directly or view it on GitHub:
https://github.com/sirkitree/bot_jira/pull/1/files#r9775598