Point taken @raydavis.  I've make that correction not only in the
bootstrap_controller_spec, but also in the act_as_user_spec.

Thanks for the comment!

Mike


On Wed, Apr 23, 2014 at 5:59 PM, Ray Davis <notifications@github.com> wrote:

> In spec/controllers/bootstrap_controller_spec.rb:
>
> > @@ -20,4 +20,16 @@
> >      end
> >    end
> >
> > +  context "for admin users" do
> > +    it "should redirect to /auth/cas?renew=true after the first time they try to act as" do
> > +      Settings.features.reauthentication = true
>
> Sorry to do this to you at the end of such a long review process, @chikoon<https://github.com/chikoon>, but I think that directly setting a constant/global inside a test
> pollutes the environment for the rest of the tests. A safer approach would
> explicitly contextualize it:
>
> context "for admin users" do
> before { Settings.features.stub(:reauthentication).and_return(true) }
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ets-berkeley-edu/calcentral/pull/2400/files#r11907675>
> .
>