I personally prefer the style but I was asked to change it elsewhere so
I've passed along the recommendation.


On Tue, Feb 4, 2014 at 10:33 AM, Dave Rogers <notifications@github.com>wrote:

> In lib/suretax/api/request.rb:
>
> > -        @return_file_code = '0'
> > -        @client_number = configuration.client_number
> > -        @validation_key = configuration.validation_key
> > -        args.each_pair do |key,value|
> > +      validate :client_number,
> > +               :business_unit,
> > +               :validation_key,
> > +               :data_year,
> > +               :data_month,
> > +               :total_revenue,
> > +               :return_file_code,
> > +               :client_tracking,
> > +               :response_group,
> > +               :response_type,
> > +               :items
> > +
>
> I like it because if we remove one, in the diff it's very clear which
> attribute we're removing. that said, I don't use it everywhere so I could
> do either
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/bqsoft/suretax/pull/27/files#r9424234>
> .
>