Done


On Mon, Mar 10, 2014 at 9:25 AM, Michael Haitz <notifications@github.com>wrote:

> In
> bootstrap-core/src/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/button/BootstrapClientSideLink.java:
>
> > +    protected void onComponentTag(ComponentTag tag) {
> > +    	super.onComponentTag(tag);
> > +    	tag.put("href",  getTarget().getObject());
> > +    }
> > +
> > +    @Override
> > +    protected void detachModel() {
> > +    	super.detachModel();
> > +    	onclickCode.detach();
> > +    }
> > +
> > +    /**
> > +     * @return returns the target.
> > +     */
> > +    protected IModel<String> getTarget() {
> > +    	return Model.of("#");
>
> # isn't a good idea, because it could lead to strange ui flickering if
> you don't return false; in your onclick method.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/l0rdn1kk0n/wicket-bootstrap/pull/338/files#r10421479>
> .
>



-- 
Regards - Ernesto Reinaldo Barreiro