Cc pdlogs 61

Updated after review comments for the ENT feature.  
Modified the messages to capitalize acronyms.  
Removed unnecessary whitespace.  
Added full stop to end of each part of the message.  
Actions are numbered if there is more than one action.  This separates the individual actions.
Separated the log definitions with a blank line to make them more readable.  
Ran astyle (according to the coding standards) against sprout_ent_definitions.h.
Fixed header file inconsistencies.
The review comment had: "A lot of the logs still say 'report issue to support' or something similar. This just isn't suitable for Project Clearwater."
The language was kept the same as this is what is done for the SNMP alarm definitions.  The associated documentation should identify the Metaswitch support team for ClearwaterCore and the Clearwater mailing list for Clearwater.
Removed signalnames.cpp.  The signal call name is now obtained from the strsignal call.
I think its in the process of bailing anyway.  See around line 1603.

From: Eleanor Merry [mailto:notifications@github.com]
Sent: Wednesday, December 17, 2014 10:14 AM
To: Metaswitch/sprout
Cc: David Collins
Subject: Re: [sprout] Cc pdlogs 61 (#895)


In include/sprout_ent_definitions.h<https://github.com/Metaswitch/sprout/pull/895#discussion-diff-21982137>:

> +  PDLogBase::CL_SPROUT_ID + 19,

> +  PDLOG_ERR,

> +  "Fatal - The SIP stack failed to initialize with error, %s.",

> +  "The SIP interfaces could not be started.",

> +  "Application will exit.",

> +  "Report the issue to support."

> +);

> +

> +static const PDLog2<const char*, int> CL_SPROUT_HTTP_INTERFACE_FAIL

> +(

> +  PDLogBase::CL_SPROUT_ID + 20,

> +  PDLOG_ERR,

> +  "An HTTP interface failed to initialize or start in %s with error %d.",

> +  "The timeout handlers for the application could not be registered with Chronos.",

> +  "Timeout events won't occur.",

> +  "Restart the application.  If the issue does not clear report the issue to support."

If hitting this log means we should restart Sprout, then we should probably be bailing out at this point. Can you change main.cpp to exit at this point?

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/sprout/pull/895/files#r21982137>.