Remove cid_client_addr

Use the gsh_client for enerything now.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Add display_sockaddr function using display_buffer

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Convert rest of SAL display functions to use display_buffer

Also assure that if a string is constructed inside an if (isDebug())
construct, that we keep track of the validity of the string so that if the
log level increases, we don't then print garbage because the string
construction was skipped earlier.

Also, most places where a pointer to a SAL type is printed with %p,
display the referenced object instead.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Remove redundant test for STATE_TYPE_SHARE in open4_do_open

When we looked for a state with the same owner, we only considered states
of type STATE_TYPE_SHARE so it is redundant to later test if the file_state
which was found is of type STATE_TYPE_SHARE.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Use sprint_sockip instead of sprint_sockaddr where appropriate

Also, in nfs_dupreq, use SOCK_NAME_MAX instead of 512 for size of buffer.
The DRC cache is per port, so sprint_sockaddr is still appropriate here.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Use gsh_client in state_nsm_client_t instead of sockaddr

In doing so, we also take a reference on the gsh_client while the nsm_client
exists so that it will be retained.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>