No strong preference


On Wed, May 21, 2014 at 10:16 AM, adamrp <notifications@github.com> wrote:

> In tests/test_parse.py:
>
> > +        t_tsv = parse_biom_table(t_tsv_stringio)
> > +        self.assertEqual(t, t_tsv)
> > +
> > +        # Test JSON as a list of lines
> > +        t_json_str = t.to_json('asd')
> > +        t_json_lines = t_json_str.splitlines()
> > +        t_json = parse_biom_table(t_json_lines)
> > +        self.assertEqual(t, t_json)
> > +        # Test JSON as a file-like object
> > +        t_json_str = t.to_json('asd')
> > +        t_json_stringio = StringIO(t_json_str)
> > +        t_json = parse_biom_table(t_json_stringio)
> > +        self.assertEqual(t, t_json)
> > +
> > +    @npt.dec.skipif(HAVE_H5PY is False, msg='H5PY is not installed')
> > +    def test_parse_biom_table_with_hdf5(self):
>
> No problem, of course -- the other approach here would be to keep a TSV or
> JSON version of the HDF5 biom file (which is located at
> tests/test_data/test.biom) handy. We would just have to keep them
> synchronized (at least the data). This would allow me to reduce the code
> duplication between these two tests. I'm open to either option!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/biocore/biom-format/pull/436/files#r12905525>
> .
>