imho visitValuesList does way too many things.