yumpkg: refine pkg.hold/unhold

This brings these functions more in line with Salt design standards, in
that an error case raises an exception which can be caught elsewhere.
Returning different data types depending on success or error, and then
doing type checking later on, is not pythonic.
aptpkg: refine pkg.hold/unhold

This brings these functions more in line with Salt design standards, in
that an error case raises an exception which can be caught elsewhere.
Returning different data types depending on success or error, and then
doing type checking later on, is not pythonic.
Refine hold/unhold behavior in pkg.installed state

This adds exception handling to more gracefully report on problems
encountered while attempting to hold packages.
Decorate tests as expensive

Less trouble for the new runtests script
Remove yum-specific code

This is what happens when you copy and paste, and don't pay attention.
Move log levels in scheduler up

Too much was being logged to debug. Make errors more promenent and
move job exec events up to info. Closes #10621
Add CommandExecutionError to exception handling

aptpkg's set_selections (called by hold/unhold) could potentially raise
this exception, so catch it as well.
aptpkg: Fix call to get_selections()

This was passing "hold" as a name, not a quoted string (which succeeded
since there is a function named "hold" in the module), causing the
retrieved selections to be empty, leading to a traceback when the
function later tries to run set_selections().
Merge pull request #13374 from cachedout/10621

Move log levels in scheduler up
Merge pull request #13366 from terminalmage/refine-pkg-hold

Refine hold/unhold behavior in pkg.installed state
Closes #13369

Need to set the password in vm_ which used to happen inside what is now
request_instance, but was never added.
Fixed docstring typo
don't always overwrite the error_msg

error_msg='Failed to upload file {0!r}: {1}\n{2}', is in scp_file
Merge pull request #13378 from rallytime/docstring_fix

Fixed docstring typo
Assert proper return types from state calls.

Just to be sure.
fix pylint errors
Stop passing `env`. Use `saltenv`.
Merge pull request #13367 from s0undt3ch/hotfix/jenkins

Decorate tests as expensive
Merge pull request #13379 from gtmanfred/exec_ssh_cmd

don't always overwrite the error_msg
Merge pull request #13377 from gtmanfred/develop

Closes #13369