Teambuilder upgrades

Moving icons to action bar
My problem is that the overflow menu doenst show if you have a menu key.

And using the menu key might be alien for some users

On 9 October 2014 22:18, NamTThai <notifications@github.com> wrote:

> In app/src/main/res/menu/team_building.xml:
>
> > -        android:orderInCategory="100"
> > -        android:showAsAction="withText"
> > -        android:title="@string/import_team" />
> > -
> > -    <item
> > -        android:id="@+id/action_export_team"
> > -        android:icon="@drawable/ic_action_import_export"
> > -
> > -        android:orderInCategory="100"
> > -        android:showAsAction="withText"
> > -        android:title="@string/export_team" />
> > +        android:title="@string/action_settings">
> > +        <menu>
> > +            <item
> > +                android:id="@+id/action_rename_team"
> > +                android:icon="@drawable/ic_action_labels"
>
> This one doesn't make much sense. If it's never shown then isn't the icon
> useless?
>
> I would say not use overflow, leave all items
> android:showAsAction="ifRoom" and Android will put them in overflow menu
> for you.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NamTThai/PokemonShowdownAndroidClient/pull/13/files#r18671251>
> .
>



-- 
BOUVET Clément
bouvetcl@gmail.com
 (+33) 6 32 66 03 06