[TASK] Unit tests to addPlugin()

Add unit tests to ExtensionManagementUtility::addPlugin() verifying
the new third parameter $extensionKey is handled properly.

Change-Id: I0257755d0708f12141c78fb97e6e342daf7a6281
Resolves: #60110
Related: #60109
Related: #59414
Related: #59770
Related: #59468
Releases: 6.2, 6.3
Reviewed-on: https://review.typo3.org/31335
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Give extension key to addPlugin() in registerPlugin()

With patch #59770 ExtensionManagementUtility::addPlugin() signature
was extended to get the extensionKey as parameter in order to not
use $GLOBALS['_EXTKEY'] anymore if possible.
The parameter is used to determine correct path to plugin icons if
the icon path is not given otherwise.
The patch changes extbase ExtensionUtility::registerPlugin() to give
the extensionKey to addPlugin, too.
With this patch registerPlugin() can be used in TCA/Overrides.
Some tests are added to verify the icon path calculation since it is
not trivial to follow the code flow with all its options and global
array access.

Change-Id: I2dd709ef7ca304bc8c4fda1e7911f18bfe7ad04c
Resolves: #60109
Related: #59770
Related: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31336
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Tooltip for a shortcut in list view shows id=0

In the list view the tooltip for a shortcut always shows
id=0 because the field shortcut is not fetched from the database.
Add this to the list of fields to select.

Resolves: #60033
Releases: 6.3,6.2
Change-Id: Id4949e6699657a57975977b3450f54bc3216d06d
Reviewed-on: https://review.typo3.org/31328
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 683ae94fb8bdf022981c9045c81e37149c32160e)
Reviewed-on: https://review.typo3.org/31337
[BUGFIX] Move TCA modification of indexed_search to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: If5998b9c86bc5f7b106fd3f1c9213842b8ae242d
Resolves: #59468
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31340
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Move TCA modification of EXT:csc to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I3a357ddff0fe5d6f16caa67b4085372c27594234
Resolves: #59465
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31339
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Move TCA modification of EXT:openid to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I7b5240eccde3d49531bb734adf26ee623829dc59
Resolves: #59698
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30910
Reviewed-by: Olivier Dobberkau
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 920f93cc4a150c74e91a65d0309291327e600c39)
Reviewed-on: https://review.typo3.org/31344
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[BUGFIX] Move TCA modification of EXT:cms to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Idb1be39c754d5566e52623103477b94887077cdb
Resolves: #59463
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30648
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 57b9fd213897663b4c12d025375a8564cb7d60b2)
Reviewed-on: https://review.typo3.org/31343
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[BUGFIX] Move TCA modification of EXT:t3editor to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I1f92a7b536ffb19d30bb580ea30452fc488cd0f6
Resolves: #59705
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31342
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[BUGFIX] Move TCA modification of EXT:form to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I789ea89318d76d0c709229139b0f5296042cded7
Resolves: #59466
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31341
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[BUGFIX] Use string as constant name in FormProtectionFactory.

Currently the constant itself is used, which leads to PHP notices if it is
not defined yet.

Resolves: #60115
Releases 6.2,6.3
Change-Id: I6932f958a9cb0d01be5910860ebbd78f2c67c58a
Reviewed-on: https://review.typo3.org/31345
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[BUGFIX] Init variable in GeneralUtility::createVersionNumberedFilename

The variable '$doNothing' was not initialized, leading to PHP notices.

Resolves: #60116
Releases: 6.3, 6.2
Change-Id: I38473b73d4b1ebeb4b1dcbea5ba24d005c520487
Reviewed-on: https://review.typo3.org/31346
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[BUGFIX] Move TCA modification of EXT:felogin to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Resolves: #59462
Related: #59414
Releases: 6.3,6.2
Change-Id: I0bd42865f199b7fcccc1ee9133776271a1af2bcd
Reviewed-on: https://review.typo3.org/31347
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Updating deactivated extensions installs them

If you update a deactivated extension it becomes activated afterwards.
This patch change from the installExtension function to
downloadMainExtension function because on updates it is enough to
download the new extension.

Resolves: #59631
Releases: 6.3, 6.2
Change-Id: Idec8c1f3521fa03241def5e171718b42cc31ce6b
Reviewed-on: https://review.typo3.org/31348
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[TASK] Cleanup EXT:version

* Update phpDoc where needed
* Import use statements where possible

Resolves: #59857
Releases: 6.3, 6.2
Change-Id: I786db3b377dbe0cc90441ea6618ce05fc67b087b
Reviewed-on: https://review.typo3.org/31349
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[BUGFIX] Empty class selector crashes Update image

Prevent the Update image dialog box to crash when trying to access
an empty class selector.

Resolves: #59938
Releases: 6.2, 6.3
Change-Id: Ida2c3dfb185064071fcdcda158f64e330562aa01
Reviewed-on: https://review.typo3.org/31350
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Move TCA modification of saltedpasswords to TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: I328cbcb718ee33beec19379ea6047a18cdc370b0
Resolves: #59704
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31351
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Move TCA modification of EXT:core to TCA/Overrides.

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes and spoil
proper caching.

Change-Id: Ia2ae5e6c9a00aade1a65a6a89ecf809a0931025f
Resolves: #59464
Related: #59414
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31352
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
[BUGFIX] Removed clickMenu code around header icon in info window

The header icon in the ElementInfo screen has a click link added
but this doesn't work and doesn't make sense as shown links would
be in the wrong context.

This patch removes the javasript to open the clickmenu from the icons.

Resolves: #56250
Releases: 6.3, 6.2
Change-Id: I2b907188958f166a129617da36585c07be3a143c
Reviewed-on: https://review.typo3.org/31358
Reviewed-by: Markus Klein
Tested-by: Markus Klein
[TASK] Clean up buildBaseTcaFromSingleFiles()

The method uses two different approaches to get a list of active
packages, this is cleaned up to use the package manager only.

Change-Id: Ifc73d36ed0020914b0f7cf0b479010f91d1eba7f
Resolves: #60121
Related: #60120
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31360
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
[BUGFIX] Warning in addPlugin()

ExtensionManagementUtility::addPlugin() may raise a warning if
a subarray of TYPO3_LOADED_EXT is not set for whatever reason.
The patch sanitizes this.

Change-Id: I4fb8c24bcdebd6b04e856ecad5da07e624d95da4
Resolves: #60122
Related: #59770
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/31361
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring