just pushed some changes addressing everything talked about so far today
with @jagtalon


On Mon, Feb 24, 2014 at 3:56 PM, Jag Talon <notifications@github.com> wrote:

> In lib/DDG/Goodie/Conversions.pm:
>
> >  };
> >
> > +# from the source ...
> > +sub looks_like_number {
> > +  local $_ = shift;
> > +
> > +  # checks from perlfaq4
> > +  return 1 unless defined;
> > +  return 1 if (/^[+-]?\d+$/); # is a +/- integer
> > +  return 1 if (/^([+-]?)(?=\d|\.\d)\d*(\.\d*)?([Ee]([+-]?\d+))?$/); # a C float
> > +  return 1 if ($] >= 5.008 and /^(Inf(inity)?|NaN)$/i) or ($] >= 5.006001 and /^Inf$/i);
> > +
> > +  0;
> > +}
> > +
> > +sub get_types_and_factors {
>
> Looks like you guys are working on two different things (he's working on
> adding temperature, and you're working on this current one). We could just
> merge the two later.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/duckduckgo/zeroclickinfo-goodies/pull/336/files#r10009855>
> .
>