change to keyup event