Remove inefficient Msf::ModuleSet#each

MSP-9228

With the new module cache, the cache should be queried first using
Mdm::Module::Instance or Mdm::Module::Class and then use
Metasploit::Framework::Module::Instance::Enumerator.
Remove inefficient Msf::ModuleSet#each_module

MSP-9228
Remove unused Msf::ModuleSet#force_load_set

MSP-9228
Remove unused Msf::ModuleSet#each_module_list

MSP-9228
Remove unused and inefficient Msf::ModuleSet#rank_modules

MSP-9228
Remove obsolete Msf::SymbolicModule

MSP-9228
Remove unused Msf::ModuleSet#ambiguous_module_reference_name_set

MSP-9228

New loader doesn't use the set.
Remove obsolete Msf::ModuleSet#architectures_by_modules

MSP-9228

Modules with a given architecture(s) should be looked up using
Mdm::Module::Instance.with_architecture_abbreviations.
Remove unused Msf::ModuleSet#mod_extensions

MSP-9228
Remove obsolete Msf::ModuleSet#platforms_by_module

MSP-9228

Modules should be searched for by platform using
Mdm::Module::Instance.intersecting_platforms or
Mdm::Module::Instance.intersecting_platform_fully_qualified_names.
Remove unused Mdm::ModuleSet#mod_sorted

MSP-9228
Remove obsolete Msf::ModuleSet#mod_ranked

MSP-9228

Can use Mdm::Module::Class.ranked or Mdm::Module::Instance.ranked scopes
instead.
Inline Msf::ModuleManager.module_set_class_by_module_type

MSP-9228

All module types now use Msf::ModuleSet, so
Msf::ModuleManager#module_set_by_module_type can just use
Msf::ModuleSet.new directly.
Remove unneeded use of ActiveSupport::Concern

MSP-9228
Inline Msf::ModuleManager Msf::ModuleSet creation

MSP-9228

Remove Msf::ModuleManager#module_set_by_module_type and create the
Msf::ModuleSet and validate it directly in the directory-specific
defined methods as this means unused Msf::ModuleSets don't have to be
created.
Remove unused require

MSP-9228
Remove unneeded use of ActiveSupport::Concern

MSP-9228
Remove unneeded use of ActiveSupport::Concern

MSP-9228
Remove connection conditionals in Msf::ModuleSet

MSP-9228

A database connection to the cache will always be available under the
sqlite cache plan.
Spec Msf::Simple::Statistics

MSP-9228