comitting assignment 1