now can handle commit