Proposing adding Norwegian Zones

<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52396237%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52399021%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52399210%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52404457%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52404583%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52416614%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52486642%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52487056%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52507244%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52784869%22%2C%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-53430185%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/zencart/zc-v1-series/pull/129%23issuecomment-52396237%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22In%20my%20opinion%20this%20should%20not%20be%20a%20part%20of%20a%20default%20instal%2C%20because%2099%25%20of%20the%20users%20will%20never%20use%20the%20Norwegian%20zones.%20I%20think%20it%20is%20better%20to%20add%20this%20as%20a%20separate%20module.%20This%20way%20the%20zones%20table%20stays%20as%20small%20as%20possible.%22%2C%20%22created_at%22%3A%20%222014-08-16T15%3A30%3A42Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/2766593%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Zen4All%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20can%20partially%20agree%20with%20you%2C%20but%20you%20could%20say%20the%20same%20thing%20about%20some%20of%20those%20already%20in%20there.%20Still%20I%20wonder%20where%20you%20got%20that%20number%20from...%20%3B%29%5Cr%5Cn%5Cr%5CnThe%20problem%20is%20that%20you%20have%20to%20choose%20a%20zone%20during%20install%2C%20and%20when%20you%20don%27t%20find%20it%20you%20get%20confused.%20At%20least%20the%20installer%20should%20only%20display%20zones%20related%20to%20the%20chosen%20country%20then%2C%20and%20if%20non%20available%20-%20skip%20it.%5Cr%5Cn%5Cr%5CnAnyhow%2C%20something%20cool%20would%20be%20an%20option%20to%20add%20localised%20sql%20files%20easily%20into%20the%20pack.%20Or%20being%20able%20to%20add%20such%20a%20file%20during%20the%20install%2C%20via%20the%20the%20installer%20script.%20Thus%20making%20it%20easy%20to%20make%20localised%20versions%20of%20Zen%20Cart.%20T.ex.%20Joomla%20has%20both%20options.%5Cr%5Cn%5Cr%5CnWould%20be%20nice%20for%20adding%20languages%2C%20localised%20settings%20for%20zones%2C%20taxes%20etc.%20-%20changes%20needed%20for%20a%20good%20start.%20Changes%20which%20is%20hard%20to%20figure%20out%20for%20a%20newcomer.%5Cr%5Cn%5Cr%5CnZen%20Cart%20has%20been%20loosing%20some%20market%20share%20in%20Norway%20and%20other%20countries%20the%20later%20years%2C%20and%20it%27s%20sad.%20Let%27s%20take%20some%20of%20it%20back%20by%20making%20it%20easier%20to%20start%20from%20scratch%20with%20it.%20This%20was%20meant%20as%20a%20small%20start...%20%3B%29%22%2C%20%22created_at%22%3A%20%222014-08-16T16%3A53%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/858132%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/syntaxerror%22%7D%7D%2C%20%7B%22body%22%3A%20%22Another%20way%20would%20be%20to%20load%20zone%20sql%20files%20after%20the%20installer%20choosing%20countries...%20then%20you%20wouldn%27t%20clutter%20up%20the%20zone%20table%20for%20all%20us%20not%20needing%20US%20zones%20etc%20neither...%20%3B%29%22%2C%20%22created_at%22%3A%20%222014-08-16T16%3A56%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/858132%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/syntaxerror%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40syntaxerror%20wrote%3A%5Cr%5Cn%3E%20Anyhow%2C%20something%20cool%20would%20be%20an%20option%20to%20add%20localised%20sql%20files%20easily%20into%20the%20pack.%20Or%20being%20able%20to%20add%20such%20a%20file%20during%20the%20install%2C%20via%20the%20the%20installer%20script.%20Thus%20making%20it%20easy%20to%20make%20localised%20versions%20of%20Zen%20Cart.%20T.ex.%20Joomla%20has%20both%20options.%5Cr%5Cn%5Cr%5CnZen%20Cart%20has%20the%20/zc_install/sql/plugins%20folder%2C%20and%20any%20.sql%20file%20you%20place%20there%20will%20be%20automatically%20parsed%20and%20loaded%20into%20the%20database%20after%20the%20base%20install%20is%20done.%22%2C%20%22created_at%22%3A%20%222014-08-16T20%3A08%3A47Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/404472%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/drbyte%22%7D%7D%2C%20%7B%22body%22%3A%20%22That%20said%2C%20I%27m%20not%20opposed%20to%20incorporating%20correctly-updated%20zone%20information%20into%20core%2C%20especially%20for%20countries%20where%20that%20information%20is%20stable%20and%20reliable.%20There%20are%20some%20countries%20where%20that%20information%20is%20constantly%20changing%20and%20including%20it%20is%20more%20problematic%20than%20helpful.%22%2C%20%22created_at%22%3A%20%222014-08-16T20%3A14%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/404472%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/drbyte%22%7D%7D%2C%20%7B%22body%22%3A%20%22Oh%2C%20I%20wasn%27t%20aware%20of%20that%20hidden%20and%20undocumented%28%3F%29%20feature.%20But%20that%20certainly%20will%20make%20my%20life%20much%20easier%20from%20now%20on.%20Thanks%20for%20the%20tip.%5Cr%5Cn%5Cr%5CnRegarding%20changes%2C%20that%20shouldn%27t%20be%20an%20issue%20for%20Norway.%20It%20has%20been%20the%20same%20since%201972%2C%20and%20is%20unlikely%20to%20change%2C%20unless%20t.ex.%20Iceland%20and/or%20Scotland%20really%20want%20to%20join%20in%20%28politics%29%20and%20is%20added%20as%20own%20zones.%20%3B%29%22%2C%20%22created_at%22%3A%20%222014-08-17T08%3A35%3A15Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/858132%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/syntaxerror%22%7D%7D%2C%20%7B%22body%22%3A%20%22Just%20a%20note%20as%20well.%5Cr%5CnIn%20the%20v160%20installer%2C%20you%20do%20not%20choose%20a%20zone.%20This%20is%20done%20in%20the%20post%20install%20setup%20wizard%20when%20you%20first%20access%20the%20admin%20system.%20%5Cr%5Cn%5Cr%5CnThere%20may%20be%20an%20argument%20for%20an%20optional%20loading%20of%20some%20sq%22%2C%20%22created_at%22%3A%20%222014-08-18T12%3A44%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/227354%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/zcwilt%22%7D%7D%2C%20%7B%22body%22%3A%20%22The%20one%20thing%20we%20don%27t%20want%20to%20do%20is%20to%20make%20the%20installer%20more%20complex.%20We%20have%20been%20working%20on%20reducing%20the%20complexity%20of%20the%20installer.%20%28From%20a%20users%20perspective%29%22%2C%20%22created_at%22%3A%20%222014-08-18T12%3A48%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/227354%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/zcwilt%22%7D%7D%2C%20%7B%22body%22%3A%20%22OK%2C%20I%20just%20%5C%22wrongly%5C%22%20referred%20to%20the%20post%20install%20as%20a%20part%20of%20the%20installation%2C%20as%20I%20see%20it%20as%20a%20needed%20step%20before%20doing%20anything%20else.%5Cr%5Cn%5Cr%5CnThe%20installation%20is%20clean%20and%20easy%20now%20yes%2C%20well%20done%20job%20on%20it.%20But%20adding%20a%20option%20for%20uploading%20a%20custom%20script%20%5C%22Advanced%20Settings%5C%22%20section%20of%20%5C%22Database%20Setup%5C%22%20would%20not%20ruin%20it%20I%20think.%20But%20at%20least%20there%20could%20be%20a%20text%20on%20that%20step%2C%20telling%20about%20the%20possibility%20to%20upload%20an%20extra%20script%20to%20the%20plugins%20folder%20via%20ftp%20before%20proceeding%3F%20Anyhow%20we%27re%20quite%20of%20topic%20now%2C%20sorry%20for%20making%20that%20happen%20by%20thinking%20out%20load.%20%3A%29%22%2C%20%22created_at%22%3A%20%222014-08-18T15%3A20%3A47Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/858132%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/syntaxerror%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%20%22%2C%20%22created_at%22%3A%20%222014-08-20T14%3A23%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/404472%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/drbyte%22%7D%7D%2C%20%7B%22body%22%3A%20%22Have%20added%20a%20proposal%20to%20allow%20uploading%20custom%20sql%20in%20the%20installer.%5Cr%5Cnhttps%3A//github.com/zencart/zc-v1-series/issues/138%5Cr%5Cn%5Cr%5CnGiven%20that%2C%20will%20close%20this%20PR%20and%20reference%20later.%22%2C%20%22created_at%22%3A%20%222014-08-26T14%3A36%3A45Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/227354%3Fv%3D2%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/zcwilt%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>
<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>
- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/zencart/zc-v1-series/pull/129#issuecomment-52396237'>General Comment</a></b>
- <a href='https://github.com/Zen4All'><img border=0 src='https://avatars.githubusercontent.com/u/2766593?v=2' height=16 width=16'></a> In my opinion this should not be a part of a default instal, because 99% of the users will never use the Norwegian zones. I think it is better to add this as a separate module. This way the zones table stays as small as possible.
- <a href='https://github.com/syntaxerror'><img border=0 src='https://avatars.githubusercontent.com/u/858132?v=2' height=16 width=16'></a> I can partially agree with you, but you could say the same thing about some of those already in there. Still I wonder where you got that number from... ;)
The problem is that you have to choose a zone during install, and when you don't find it you get confused. At least the installer should only display zones related to the chosen country then, and if non available - skip it.
Anyhow, something cool would be an option to add localised sql files easily into the pack. Or being able to add such a file during the install, via the the installer script. Thus making it easy to make localised versions of Zen Cart. T.ex. Joomla has both options.
Would be nice for adding languages, localised settings for zones, taxes etc. - changes needed for a good start. Changes which is hard to figure out for a newcomer.
Zen Cart has been loosing some market share in Norway and other countries the later years, and it's sad. Let's take some of it back by making it easier to start from scratch with it. This was meant as a small start... ;)
- <a href='https://github.com/syntaxerror'><img border=0 src='https://avatars.githubusercontent.com/u/858132?v=2' height=16 width=16'></a> Another way would be to load zone sql files after the installer choosing countries... then you wouldn't clutter up the zone table for all us not needing US zones etc neither... ;)
- <a href='https://github.com/drbyte'><img border=0 src='https://avatars.githubusercontent.com/u/404472?v=2' height=16 width=16'></a> @syntaxerror wrote:
> Anyhow, something cool would be an option to add localised sql files easily into the pack. Or being able to add such a file during the install, via the the installer script. Thus making it easy to make localised versions of Zen Cart. T.ex. Joomla has both options.
Zen Cart has the /zc_install/sql/plugins folder, and any .sql file you place there will be automatically parsed and loaded into the database after the base install is done.
- <a href='https://github.com/drbyte'><img border=0 src='https://avatars.githubusercontent.com/u/404472?v=2' height=16 width=16'></a> That said, I'm not opposed to incorporating correctly-updated zone information into core, especially for countries where that information is stable and reliable. There are some countries where that information is constantly changing and including it is more problematic than helpful.
- <a href='https://github.com/syntaxerror'><img border=0 src='https://avatars.githubusercontent.com/u/858132?v=2' height=16 width=16'></a> Oh, I wasn't aware of that hidden and undocumented(?) feature. But that certainly will make my life much easier from now on. Thanks for the tip.
Regarding changes, that shouldn't be an issue for Norway. It has been the same since 1972, and is unlikely to change, unless t.ex. Iceland and/or Scotland really want to join in (politics) and is added as own zones. ;)
- <a href='https://github.com/zcwilt'><img border=0 src='https://avatars.githubusercontent.com/u/227354?v=2' height=16 width=16'></a> Just a note as well.
In the v160 installer, you do not choose a zone. This is done in the post install setup wizard when you first access the admin system.
There may be an argument for an optional loading of some sq
- <a href='https://github.com/zcwilt'><img border=0 src='https://avatars.githubusercontent.com/u/227354?v=2' height=16 width=16'></a> The one thing we don't want to do is to make the installer more complex. We have been working on reducing the complexity of the installer. (From a users perspective)
- <a href='https://github.com/syntaxerror'><img border=0 src='https://avatars.githubusercontent.com/u/858132?v=2' height=16 width=16'></a> OK, I just "wrongly" referred to the post install as a part of the installation, as I see it as a needed step before doing anything else.
The installation is clean and easy now yes, well done job on it. But adding a option for uploading a custom script "Advanced Settings" section of "Database Setup" would not ruin it I think. But at least there could be a text on that step, telling about the possibility to upload an extra script to the plugins folder via ftp before proceeding? Anyhow we're quite of topic now, sorry for making that happen by thinking out load. :)
- <a href='https://github.com/drbyte'><img border=0 src='https://avatars.githubusercontent.com/u/404472?v=2' height=16 width=16'></a> :+1:
- <a href='https://github.com/zcwilt'><img border=0 src='https://avatars.githubusercontent.com/u/227354?v=2' height=16 width=16'></a> Have added a proposal to allow uploading custom sql in the installer.
https://github.com/zencart/zc-v1-series/issues/138
Given that, will close this PR and reference later.


<a href='https://www.codereviewhub.com/zencart/zc-v1-series/pull/129?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/zencart/zc-v1-series/pull/129?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/zencart/zc-v1-series/pull/129'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>
<a href='#crh-end'></a>