Agree. This test doesn't tag I don't think. Tags should always be SemVer compliant.

The idea is the version goes to master when its merged in. Then you would tag the proper SemVer at some point.

Sent from my Windows Phone
________________________________
From: Andreas Öhlund<mailto:notifications@github.com>
Sent: ‎5/‎10/‎2014 7:31 PM
To: Particular/GitVersion<mailto:GitVersion@noreply.github.com>
Cc: Jake Ginnivan<mailto:jake@ginnivan.net>
Subject: Re: [GitVersion] Create pre-release package with tag based on branch name in GitHubFlow (#155)


In AcceptanceTests/GitHubFlow/OtherBranchTests.cs:

> +    using LibGit2Sharp;
> +    using Shouldly;
> +    using Xunit;
> +
> +    public class OtherBranchTests
> +    {
> +        [Fact]
> +        public void CanTakeVersionFromReleaseBranch()
> +        {
> +            using (var fixture = new EmptyRepositoryFixture())
> +            {
> +                const string TaggedVersion = "1.0.3";
> +                fixture.Repository.MakeATaggedCommit(TaggedVersion);
> +                fixture.Repository.MakeCommits(5);
> +                fixture.Repository.CreateBranch("alpha-2.0.0");
> +                fixture.Repository.Checkout("alpha-2.0.0");


At least that is my thinking. That way if eg. github would sort tags by semver they would show up correctly. Regarding branches we just used the "gitflow" convention and since branches can be called whatever it doesn't seem as importartant to semver align them?

—
Reply to this email directly or view it on GitHub<https://github.com/Particular/GitVersion/pull/155/files#r12505534>.