worked on logincontroller