On 04/02/14 16:14, Chris St. Pierre wrote:
> In src/lib/Bcfg2/Client/Tools/POSIX/base.py:
>
>>                  acl.delete_entry(aclentry)
>>          if os.path.isdir(path):
>>              defacl = posix1e.ACL(filedef=path)
>> -            if not defacl.valid():
>> -                # when a default ACL is queried on a directory that
>
> So if an empty default ACL isn't invalid, do we even need the |if
> defacl.valid():| check on line 222 below?

I think that if is actually redundant now you put it like that. The for 
loop will simply iterate 0 times on an empty ACL.

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Bcfg2/bcfg2/pull/156/files#r9426195>.
>